#17741 closed update (fixed)
UPDATE: fox-1.6.34
| Reported by: | lyle@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.7.0 |
| Keywords: | Cc: | ryandesign (Ryan Carsten Schmidt) | |
| Port: | fox |
Description
This patch updates the fox portfile to version 1.6.34. It also corrects a build-time bug related to the Freetype2 dependency.
Attachments (1)
Change History (8)
comment:1 follow-up: 2 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | ryandesign@… added; lyle@… removed |
|---|
comment:2 Changed 15 years ago by lyle@…
Replying to ryandesign@…:
What is the built-time bug?
I've recently received two different bug reports that were similar to #14807 (although I had forgotten about that one). Basically, it was that the build would break when trying to compile a file which included <freetype/config/ftheader.h> because -I/${prefix}/include/freetype2 wasn't in the include path.
I see you're adding a dependency on freetype and adding
-I/${prefix}/include/freetype2to the cppflags... but I thought the decision in #14807 was that no change to the cppflags was necessary?
You're right, that addition was a mistake. The only change that needs to be made is to add the dependency on port:freetype. Once that's in place, the fox configure script will amend the include path itself properly.
comment:3 Changed 15 years ago by lyle@…
You know, let's hold off on this for the moment. I'd like to do a clean install of MacPorts and confirm that the dependencies are really correct.
Changed 15 years ago by lyle@…
| Attachment: | Portfile.diff.txt added |
|---|
Updated diff against current fox Portfile
comment:4 Changed 15 years ago by lyle@…
OK, I think this is it. Adding a dependency on port:freetype is not enough, because the fox configure script attempts to use the pkg-config utility to determine how it should modify the CFLAGS (i.e. what to add to the compile-time include path). So we actually need dependencies on port:freetype and port:pkgconfig. I've updated the patch to reflect these changes.
comment:5 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Ok, sounds good. I committed it in r44292 except that pkgconfig is a build dependency not a library dependency.
comment:6 Changed 15 years ago by jmroot (Joshua Root)
| Type: | enhancement → update |
|---|
Replying to lyle@…:
What is the built-time bug? I see you're adding a dependency on freetype and adding
-I/${prefix}/include/freetype2to the cppflags. (That should be-I${prefix}/include/freetype2by the way.) But I thought the decision in #14807 was that no change to the cppflags was necessary? On my system it links with freetype without this change.