rrdtool 1.3.5: missing #include <libgen.h> for basename() in rrd_graph.c

[vinc17@…]

I've reported the following bug to upstream: ​http://oss.oetiker.ch/rrdtool-trac/ticket/202

With RRDtool 1.3.5 under Mac OS X at least, one needs a

#include <libgen.h>

line in rrd_graph.c, as the prototype of the basename() function (used in this C source) is defined in this header. Otherwise there's a type mismatch (the compiler emits warnings), which may have incorrect side effects on some platforms (e.g., if the pointers do not have the same size as an int).

See attached patch.

[vinc17@…]

Fixed in 1.3.6.

[anonymous]

Milestone Port Bugs deleted