Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#17772 closed defect (fixed)

rrdtool 1.3.5: missing #include <libgen.h> for basename() in rrd_graph.c

Reported by: vinc17@… Owned by: markd@…
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: build Cc:
Port: rrdtool

Description

I've reported the following bug to upstream: http://oss.oetiker.ch/rrdtool-trac/ticket/202

With RRDtool 1.3.5 under Mac OS X at least, one needs a

#include <libgen.h>

line in rrd_graph.c, as the prototype of the basename() function (used in this C source) is defined in this header. Otherwise there's a type mismatch (the compiler emits warnings), which may have incorrect side effects on some platforms (e.g., if the pointers do not have the same size as an int).

See attached patch.

Attachments (1)

include.diff (834 bytes) - added by vinc17@… 15 years ago.

Download all attachments as: .zip

Change History (3)

Changed 15 years ago by vinc17@…

Attachment: include.diff added

comment:1 Changed 15 years ago by vinc17@…

Resolution: fixed
Status: newclosed

Fixed in 1.3.6.

comment:2 Changed 15 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.