port distfiles shouldn't require root

[ryandesign (Ryan Carsten Schmidt)]

port distfiles shouldn't require root access to run, since it's only displaying information:

$ port distfiles apache2
Error: Unable to execute port: /opt/local/var/macports/build/_Users_rschmidt_macports_dports_www_apache2/work/.macports.apache2.state is not writable - check permission on port directory
$

[danielluke (Daniel J. Luke)]

It looks like it just wants root to write the statefile (which it probably shouldn't need to do), so if you've been building things as non-root, it wouldn't need root.

[ryandesign (Ryan Carsten Schmidt)]

Right, but does it really need to write a statefile? port lint and port livecheck were recently enhanced to not require root; I figured a similar change could be made to port distfiles.

[afb@…]

macports-diststate.diff

[afb@…]

Same goes for port distcheck, it uses an (outdated) hard-coded list of targets rather than checking target_state

[raimue (Rainer Müller)]

Fixed in r48483.

dlist_search is maybe not the fastest option to implement this, I copied this from eval_targets.