Sox 14.2.0 upgrade

[jm@…]

Hello,

I was not able to test this port file upgrade.

portindex returns: Creating software index in /Users/kdenlive/ports Failed to parse file audio/sox/Portfile: can't set "depends_lib": invalid depspec: Adding port multimedia/frei0r-plugins Adding port multimedia/gavl Adding port multimedia/mlt

Total number of ports parsed: 4 Ports successfully parsed: 3 Ports failed: 1

[devans@…]

JM --

First of all, you don't need to run portindex to test your changes. Normally portindex is run on the server once an hour (as needed) so you never really have to do anything about it.

You can just cd to the port directory and run

sudo port install

and it will install the Portfile in the local directory (if there is one).

You can use the -d option if you want a verbose debugging output to see what's doing on.

Second, I don't see why you need to include the no_gpl at all. This was copied from ffmpeg but there it is used because thats the way the ffmpeg developers look at things. But in general as has been stated elsewhere (and you can appreciate) that the fewer variants the better. So I'd just take that out.

Small points:

• I don't think lame and vorbis are GPL, ffmpeg treats them as LGPL
• the tag at the top of the port file should be $Id$ initially (this will automatically be replaced by a time stamp by svn when committed.)

Once you have tested the port and are ready to commit, I can help you with that if you like. Will test the port here as well.

[devans@…]

Attached is a patch file that expresses your changes relative to the previous Portfile. This is the preferred way when modifying an existing port (rather than submitting a full Portfile). Start with the svn copy and apply this patch then work from there. This one is building here for me now.

[jm@…]

Thank you for your comments. I agree there is no need to provide variants. I checked out the SVN tree. Then applied your patch. Then removed the variants. I could build without problem.

Now, I try to svn diff, but it returns: Index: Portfile =================================================================== svn: Impossible de convertir la cha?\195?\174ne de 'UTF-8' vers l'encodage natif: svn: --- Portfile (r?\195?\169vision 46144) +++ Portfile (copie de travail)

I understand the problem. I access a remote MacOsX computer, which does not seem to have UTF-8 enabled.

[devans@…]

Yes, I can build it here successfully as well (Mac OS X 10.4.11 ppc). Attached is a revised version of the patch with the variant removed. Let me know if you would like me to commit these changes when you are satisfied that it is working properly.

[devans@…]

Patch for Portfile (rev 2)

[jm@…]

Perfect for me. Please commit. Thank you very much.

[devans@…]

OK, just a few more items after looking at configure:

• the --enable-x items in configure.args are unnecessary as configure will check for each item unless you say --without-x
• the following dependencies are missing:
• port:file (for libmagic)
• port:libpng
• port:wavpack (for libwavpack)

if you approve, I can make these changes before committing.

[devans@…]

Tested and committed with suggested changes in r46163 with maintainers consent via email.

[anonymous]

Milestone Port Updates deleted