New Ticket     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #18402 (closed enhancement: fixed)

Opened 3 years ago

Last modified 11 months ago

lua @5.1.4: should install both static and dynamic libraries

Reported by: cheunghonyu@… Owned by: pmq@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc: arsenm2@…, ryandesign@…, and.damore@…, mail@…
Port: lua

Description

Dear maintainers,

I want to use latest version of mod_security for my apache2 server.

According to  http://www.modsecurity.org/documentation/modsecurity-apache/2.5.7/html-multipage/installation.html

mod_security optional requires the dynamic libraries of lua. May you create a variant for buliding /opt/local/lib/liblua.dylib of lua package?

Thank you for you help

Attachments

patch-lua-#18402-1.diff Download (5.5 KB) - added by and.damore@… 11 months ago.

Change History

  Changed 3 years ago by macsforever2000@…

  • keywords lua removed
  • owner changed from macports-tickets@… to pmq@…

  Changed 3 years ago by anonymous

  • milestone Port Enhancements deleted

Milestone Port Enhancements deleted

  Changed 12 months ago by ryandesign@…

The lua Makefile does not contain any instructions for building a dynamic library, so we would have to invent it ourselves.

follow-up: ↓ 6   Changed 12 months ago by ryandesign@…

A variant would not be appropriate, by the way; the port should simply always build both a static and a dynamic library.

  Changed 12 months ago by ryandesign@…

There seems to be a patch for this in #27378.

in reply to: ↑ 4 ; follow-up: ↓ 10   Changed 12 months ago by and.damore@…

Replying to ryandesign@…:

A variant would not be appropriate, by the way; the port should simply always build both a static and a dynamic library.

Why both?

Dylib patches has been committed r76094 but it will only build dylib, whose lack was preventing some module from loading.

  Changed 12 months ago by and.damore@…

  • version changed from 1.7.0 to 1.9.2

  Changed 12 months ago by jmr@…

  • summary changed from lua 5.1.4 request a variant option for building dynamic library of lua to lua @5.1.4: should install both static and dynamic libraries

  Changed 12 months ago by arsenm2@…

  • cc arsenm2@… added

Cc Me!

in reply to: ↑ 6   Changed 11 months ago by ryandesign@…

  • status changed from new to closed
  • resolution set to fixed

Replying to and.damore@…:

Replying to ryandesign@…:

the port should simply always build both a static and a dynamic library.

Why both?

It's a recommendation I've long heard. Presumably it's to allow the user flexibility in how they want to use the library. Perhaps it's not so important.

Dylib patches has been committed r76094 but it will only build dylib, whose lack was preventing some module from loading.

This caused build failures for universal and non-default build_arch; fixed in r77088.

  Changed 11 months ago by ryandesign@…

  • cc ryandesign@…, and.damore@… added

  Changed 11 months ago by mail@…

  • cc mail@… added

Cc Me!

  Changed 11 months ago by mail@…

I am missing the disappeared static lib of lua and had to build it by hand now. I would really appreciate if, as mentioned in the ticket summary, both, static and dynamic library would be installed by default.

  Changed 11 months ago by ryandesign@…

  • status changed from closed to reopened
  • resolution fixed deleted

Right. Well, if someone can modify the Makefile patches to do this, that would be great.

  Changed 11 months ago by and.damore@…

I'm attaching a patch, this builds both archive and dylib.

I split files, I prefer one patchfile per file.

Changed 11 months ago by and.damore@…

  Changed 11 months ago by and.damore@…

  • status changed from reopened to closed
  • resolution set to fixed

Committed r77328, ticket closed.

  Changed 11 months ago by mail@…

Thanks a lot. Works great now.

  Changed 11 months ago by and.damore@…

You're welcome.

Note: See TracTickets for help on using tickets.