#18402 closed enhancement (fixed)
lua @5.1.4: should install both static and dynamic libraries
| Reported by: | cheunghonyu@… | Owned by: | pmq@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.9.2 |
| Keywords: | Cc: | arsenm2@…, ryandesign (Ryan Carsten Schmidt), anddam (Andrea D'Amore), mail@… | |
| Port: | lua |
Description
Dear maintainers,
I want to use latest version of mod_security for my apache2 server.
According to http://www.modsecurity.org/documentation/modsecurity-apache/2.5.7/html-multipage/installation.html
mod_security optional requires the dynamic libraries of lua. May you create a variant for buliding /opt/local/lib/liblua.dylib of lua package?
Thank you for you help
Attachments (1)
Change History (19)
comment:1 Changed 15 years ago by mf2k (Frank Schima)
| Keywords: | lua removed |
|---|---|
| Owner: | changed from macports-tickets@… to pmq@… |
comment:2 Changed 15 years ago by (none)
| Milestone: | Port Enhancements |
|---|
comment:3 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
The lua Makefile does not contain any instructions for building a dynamic library, so we would have to invent it ourselves.
comment:4 follow-up: 6 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
A variant would not be appropriate, by the way; the port should simply always build both a static and a dynamic library.
comment:5 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
There seems to be a patch for this in #27378.
comment:6 follow-up: 10 Changed 13 years ago by anddam (Andrea D'Amore)
Replying to ryandesign@…:
A variant would not be appropriate, by the way; the port should simply always build both a static and a dynamic library.
Why both?
Dylib patches has been committed r76094 but it will only build dylib, whose lack was preventing some module from loading.
comment:7 Changed 13 years ago by anddam (Andrea D'Amore)
| Version: | 1.7.0 → 1.9.2 |
|---|
comment:8 Changed 13 years ago by jmroot (Joshua Root)
| Summary: | lua 5.1.4 request a variant option for building dynamic library of lua → lua @5.1.4: should install both static and dynamic libraries |
|---|
comment:10 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Replying to and.damore@…:
Replying to ryandesign@…:
the port should simply always build both a static and a dynamic library.
Why both?
It's a recommendation I've long heard. Presumably it's to allow the user flexibility in how they want to use the library. Perhaps it's not so important.
Dylib patches has been committed r76094 but it will only build dylib, whose lack was preventing some module from loading.
This caused build failures for universal and non-default build_arch; fixed in r77088.
comment:11 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | ryandesign@… and.damore@… added |
|---|
comment:13 Changed 13 years ago by mail@…
I am missing the disappeared static lib of lua and had to build it by hand now. I would really appreciate if, as mentioned in the ticket summary, both, static and dynamic library would be installed by default.
comment:14 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Right. Well, if someone can modify the Makefile patches to do this, that would be great.
comment:15 Changed 13 years ago by anddam (Andrea D'Amore)
I'm attaching a patch, this builds both archive and dylib.
I split files, I prefer one patchfile per file.
Changed 13 years ago by anddam (Andrea D'Amore)
| Attachment: | patch-lua-#18402-1.diff added |
|---|
comment:16 Changed 13 years ago by anddam (Andrea D'Amore)
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Committed r77328, ticket closed.
Milestone Port Enhancements deleted