reinplace: could not set group for file "${worksrcpath}/Makefile": not owner

[ryandesign (Ryan Carsten Schmidt)]

On an Intel Mac with Mac OS X 10.4.11 and Xcode 2.5 with MacPorts running from trunk where MacPorts is not installed as the root user I now get a permission error when trying to patch bzip2. In the post-patch phase, bzip2 uses reinplace.

$ port -d install bzip2
DEBUG: Changing to port directory: /Users/rschmidt/macports/dports/archivers/bzip2
DEBUG: OS Platform: darwin
DEBUG: OS Version: 8.11.1
DEBUG: Mac OS X Version: 10.4
DEBUG: System Arch: i386
DEBUG: setting option os.universal_supported to yes
DEBUG: org.macports.load registered provides 'load', a pre-existing procedure. Target override will not be provided
DEBUG: org.macports.distfiles registered provides 'distfiles', a pre-existing procedure. Target override will not be provided
DEBUG: universal variant already exists, so not adding the default one
DEBUG: Requested variant i386 is not provided by port bzip2.
DEBUG: Requested variant macosx is not provided by port bzip2.
DEBUG: Executing variant darwin provides darwin
DEBUG: Changing to port directory: /Users/rschmidt/macports/dports/archivers/bzip2
DEBUG: OS Platform: darwin
DEBUG: OS Version: 8.11.1
DEBUG: Mac OS X Version: 10.4
DEBUG: System Arch: i386
DEBUG: setting option os.universal_supported to yes
DEBUG: org.macports.load registered provides 'load', a pre-existing procedure. Target override will not be provided
DEBUG: org.macports.distfiles registered provides 'distfiles', a pre-existing procedure. Target override will not be provided
DEBUG: universal variant already exists, so not adding the default one
DEBUG: Requested variant i386 is not provided by port bzip2.
DEBUG: Requested variant macosx is not provided by port bzip2.
DEBUG: Executing variant darwin provides darwin
DEBUG: Executing org.macports.main (bzip2)
--->  Fetching bzip2
DEBUG: Executing org.macports.fetch (bzip2)
--->  Verifying checksum(s) for bzip2
DEBUG: Executing org.macports.checksum (bzip2)
--->  Checksumming bzip2-1.0.5.tar.gz
DEBUG: Correct (md5) checksum for bzip2-1.0.5.tar.gz
DEBUG: Correct (sha1) checksum for bzip2-1.0.5.tar.gz
DEBUG: Correct (rmd160) checksum for bzip2-1.0.5.tar.gz
--->  Extracting bzip2
DEBUG: Executing org.macports.extract (bzip2)
--->  Extracting bzip2-1.0.5.tar.gz
DEBUG: setting option extract.args to /mp/var/macports/distfiles/bzip2/bzip2-1.0.5.tar.gz
DEBUG: Environment: MACOSX_DEPLOYMENT_TARGET='10.4'
DEBUG: Assembled command: 'cd "/mp/var/macports/build/_Users_rschmidt_macports_dports_archivers_bzip2/work" && gzip -dc /mp/var/macports/distfiles/bzip2/bzip2-1.0.5.tar.gz | /usr/bin/gnutar --no-same-owner -xf -'
DEBUG: Executing org.macports.patch (bzip2)
--->  Applying patches to bzip2
--->  Applying /Users/rschmidt/macports/dports/archivers/bzip2/files/patch-Makefile-man.diff
DEBUG: Environment: MACOSX_DEPLOYMENT_TARGET='10.4'
DEBUG: Assembled command: 'cd "/mp/var/macports/build/_Users_rschmidt_macports_dports_archivers_bzip2/work/bzip2-1.0.5" && patch -p0'
patching file Makefile
Hunk #1 succeeded at 72 (offset 12 lines).
Hunk #2 succeeded at 83 (offset 12 lines).
Hunk #3 succeeded at 99 with fuzz 2 (offset 12 lines).
--->  Applying /Users/rschmidt/macports/dports/archivers/bzip2/files/patch-Makefile-links.diff
DEBUG: Environment: MACOSX_DEPLOYMENT_TARGET='10.4'
DEBUG: Assembled command: 'cd "/mp/var/macports/build/_Users_rschmidt_macports_dports_archivers_bzip2/work/bzip2-1.0.5" && patch -p0'
patching file Makefile
Hunk #1 succeeded at 90 with fuzz 2.
--->  Applying /Users/rschmidt/macports/dports/archivers/bzip2/files/patch-Makefile-dylib.diff
DEBUG: Environment: MACOSX_DEPLOYMENT_TARGET='10.4'
DEBUG: Assembled command: 'cd "/mp/var/macports/build/_Users_rschmidt_macports_dports_archivers_bzip2/work/bzip2-1.0.5" && patch -p0'
patching file Makefile
Hunk #3 succeeded at 98 with fuzz 2.
Hunk #4 succeeded at 123 with fuzz 1.
DEBUG: Executing proc-post-org.macports.patch-patch-0
Error: Target org.macports.patch returned: could not set group for file "/mp/var/macports/build/_Users_rschmidt_macports_dports_archivers_bzip2/work/bzip2-1.0.5/Makefile": not owner
Warning: the following items did not execute (for bzip2): org.macports.activate org.macports.patch org.macports.configure org.macports.build org.macports.destroot org.macports.install
Error: Status 1 encountered during processing.

r45851 caused this.

[jmroot (Joshua Root)]

So what attributes do the Makefile and the temp file have?

[raimue (Rainer Müller)]

I would rather suspect this was caused by r46146.

[jmroot (Joshua Root)]

As that commit message says, the first thing in the list returned by file attributes is the group. So it still would have been trying to set the group before it was fixed to set all the attributes. This is apparently a difference in attribute preservation between cp and file copy.

[raimue (Rainer Müller)]

This patch has been committed by jmr@ in r47026 and was updated to support filenames with spaces in r47610.

[jmroot (Joshua Root)]

I have no idea whether that patch actually helps with Ryan's problem. It was just a guess that maybe if the user was set at the same time as the other attributes, it might work. If it doesn't help, I'm still waiting on an answer to the question in comment:1 BTW.

[jmroot (Joshua Root)]

Not going to hold 1.8 back for this.

[jmroot (Joshua Root)]

#20330 has a patch.

[ryandesign (Ryan Carsten Schmidt)]

Replying to jmr@…:

Not going to hold 1.8 back for this.

But it is a regression from 1.7.1, which has no problem installing bzip2 when MacPorts is installed as non-root.

[jmroot (Joshua Root)]

I'm sure it will go into 1.8 now that there's a patch, but you never provided the requested information, nor reported whether the patch had any effect.