Ticket #18634 (closed defect: fixed)
Port p5-mail-spf has missing dependencies
| Reported by: | scott@… | Owned by: | compconsultant@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.7.0 |
| Keywords: | Cc: | mcalhoun@… | |
| Port: | p5-mail-spf |
Description
I had no other ports installed, ran sudo port -d install p5-mail-spf and it was missing dependencies.
I had created a diff for solving this
Attachments
Change History
Changed 4 years ago by scott@…
- Attachment Portfile-p5-mail-spf.diff added
comment:1 Changed 4 years ago by macsforever2000@…
- Cc compconsultant@… removed
- Owner changed from macports-tickets@… to compconsultant@…
- Type changed from enhancement to defect
comment:3 Changed 4 years ago by compconsultant@…
Did you want me to do something? It's assigned to me, but, I see you guys already had the fix.
comment:4 Changed 4 years ago by scott@…
I do not think so. I just added you to the CC list since that is what the docs suggested to do. I believe, you may need to give your nod of approval in order for this port to get approved, since you are the maintainer.
comment:5 Changed 4 years ago by compconsultant@…
It looks good to me, sorry, I don't have a machine that I can start from scratch right now to test it. Please committ unless someone else disagrees?
comment:6 Changed 4 years ago by scott@…
Thanks for the follow up. I put it on a MacMini, clean install, seems to have worked fine.
comment:7 Changed 4 years ago by scott@…
Can I get a status update on this, and an idea of when it may be approved, or of there is something wrong, please let me know so I can solve it?
comment:9 follow-up: ↓ 10 Changed 3 years ago by jmr@…
- Status changed from new to closed
- Resolution set to fixed
Committed in r65337. There's no automatic way for a committer to know that a ticket has a patch that has been approved by the maintainer and needs committing, you have to ask. The macports-dev list and IRC are good places to do this. I only found this ticket because someone filed a duplicate.
comment:10 in reply to: ↑ 9 Changed 3 years ago by scott@…
Replying to jmr@…:
Committed in r65337. There's no automatic way for a committer to know that a ticket has a patch that has been approved by the maintainer and needs committing, you have to ask. The macports-dev list and IRC are good places to do this. I only found this ticket because someone filed a duplicate.
Maybe trac has a feature that could be enabled, or a convention that could be adopted, to solve that problem? When a patch is approved by the maintainer, they could add a note that says "MANC" (Maintainer Approved; Need Committing). While not perfect in any way, it is a unique string that could be searched on, and loaded as an RSS feed I believe.
Thank you for the explanation, I was not aware of this.
Would a very simple web app that users could post the url to trac tickets that needed committing be of use? Each post would poll the url and look for the "resolution" field. When resolved, closed, patched, committed, etc, it would be marked to no longer show in the list of pending "needs committing".
Please use this diff, first diff had doubling of dependencies