spidermonkey: UTF-8 Support

[ruediger@…]

I'm trying to create a macport file for the ​Flusspferd JavaScript library which depends on spidermonkey having UTF-8 support. Unfortunately spidermonkey is build without UTF-8 support and there is no variant to do so.

To build spidermonkey with UTF-8 support you have to set DEFINES to -DJS_C_STRINGS_ARE_UTF8

so something along those lines should do it:

variant utf8 description {add UTF-8 support} {
  build.args-append \
  DEFINES=-DJS_C_STRINGS_ARE_UTF8
}

[mf2k (Frank Schima)]

Is there any reason not to always build it with UTF-8 support?

[ruediger@…]

Is there any reason not to always build it with UTF-8 support?

Non that I could think of.

[mf2k (Frank Schima)]

Cc Me!

[ruediger@…]

Is there any hope on getting this fixed?

[mf2k (Frank Schima)]

Maintainer timeout.

[mf2k (Frank Schima)]

Committed revision r48945.

[mf2k (Frank Schima)]

To be clear, I added UTF-8 support without a variant.

[ruediger@…]

Sorry the Patch doesn't seem to work. You can check if spidermonkey supports UTF-8 with the following Code

#include <js/jsapi.h>
#include <stdio.h>
int main() {
  if(JS_CStringsAreUTF8())
    puts("Spidermonkey supports UTF8");
  else
    puts("no UTF8 support");
}

gcc -pedantic -Wall -W -std=c99 -g3 testutf8.c -I/opt/local/include -L/opt/local/lib -ljs -DXP_UNIX

Maybe a better way would be to add the -DJS_C_STRINGS_ARE_UTF8 to the OS_CFLAGS on line 13 in source:trunk/dports/lang/spidermonkey/files/patch-config-Darwin.mk​ (if the patch is still applied)

Building Spidermonkey can be quite a pain in the ass :(.

[mf2k (Frank Schima)]

Committed revision r49070. This works for me. Thanks!

[ruediger@…]

Works for me, too. Thank you!

[(none)]

Milestone Port Bugs deleted