#19007 closed defect (fixed)
Update solfege to include needed MIDI player, plus user instructions
| Reported by: | allencmcbride@… | Owned by: | raimue (Rainer Müller) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.7.0 |
| Keywords: | solfege midi qtplay | Cc: | raimue (Rainer Müller) |
| Port: | solfege |
Description
This patch updates the solfege port to fix a mistake I made. I now include qtplay as a dependency, as well as user instructions for initial setup. The author of solfege is working to eliminate the need for the extra setup steps, and I will update the port again when that is finished.
Attachments (4)
Change History (10)
Changed 15 years ago by allencmcbride@…
| Attachment: | Portfile-solfege.diff added |
|---|
Changed 15 years ago by raimue (Rainer Müller)
| Attachment: | Portfile-solfege-raimue.diff added |
|---|
A better approach
Changed 15 years ago by raimue (Rainer Müller)
| Attachment: | patch-default-config.diff added |
|---|
files/patch-default-config.diff
comment:1 Changed 15 years ago by raimue (Rainer Müller)
| Owner: | changed from macports-tickets@… to raimue@… |
|---|---|
| Status: | new → assigned |
I updated the Portfile with a better approach. This patches the default.config, so the user does not have to make any manual changes.
Please approve for commit :-)
Changed 15 years ago by allencmcbride@…
| Attachment: | patch-default-config.2.diff added |
|---|
slight tweak: set qtplay for wav and mp3 playback, remove no longer needed "%s"
comment:2 Changed 15 years ago by allencmcbride@…
Sounds great to me... I had thought about doing that (not that I knew how), but I was put off by the comment at the top of default.config: "Changing a variable require a new app/rcfileversion number, and manual changing in SolfegeApp.check_rcfile". Maybe that means you can't change the name of a variable, or maybe I'm misunderstanding what a variable is in this context? Anyway, other than that worry your approach sounds perfect, and I uploaded another version of your patch-default-config.diff, with two changes: First, I use qtplay for WAV and MP3 playback too, since it's capable of them. Second, I took out the %s after qtplay for simplicity's sake, since it isn't necessary as long as there aren't other command line options used.
Thanks! --Allen
comment:3 Changed 15 years ago by allencmcbride@…
Oh, and I should mention I did test all this on my system and it seems to work fine.
comment:4 Changed 15 years ago by raimue (Rainer Müller)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Committed in r48771.
patch for solfege to include qtplay, instructions