Opened 15 years ago

Closed 15 years ago

#19184 closed defect (duplicate)

add no_x11 variant for giflib and libungif

Reported by: illogic-al@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.7.1
Keywords: Cc:
Port: giflib a

Description

I have a patch here to include the no_x11 variant in giflib as it does not need it. I've been using it with my own kde portfiles for months now to no ill effect. As the kde4 based ports don't require X, it would be good to have this variant available.

Index: ../graphics/giflib/Portfile
===================================================================
--- ../graphics/giflib/Portfile (revision 47836)
+++ ../graphics/giflib/Portfile (working copy)
@@ -28,4 +28,10 @@
 
 use_parallel_build              yes
 
+variant no_x11 {
+    depends_lib-delete          port:xorg-libsm \
+                                port:xorg-libX11
+    patchfiles-delete           patch-gif_lib.h.diff
+}
+
 livecheck.regex                 "<title>${name} [lindex [split ${version} .] 0].x ${name}-(\\d+(?:\\.\\d+)*) released .*</title>"

I would also be fine with a x11 variant (as with libungif port)

Change History (4)

comment:1 Changed 15 years ago by illogic-al@…

That + patchfiles-delete patch-gif_lib.h.diff line snuck in. I'm testing the effect of that so it should not be a part of the variant.

comment:2 Changed 15 years ago by illogic-al@…

Owner: changed from macports-tickets@… to ryandesign@…

comment:3 Changed 15 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

comment:4 Changed 15 years ago by tobypeterson

Resolution: duplicate
Status: newclosed

duplicate of #18643

Note: See TracTickets for help on using tickets.