New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #19851 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Doxygen @ 1.5.9 - Patch Fails on Tiger

Reported by: ctempleton3@… Owned by: css@…
Priority: Normal Milestone:
Component: ports Version: 1.7.1
Keywords: patch Cc: ctempleton3@…,
Port: doxygen

Description

I would assume there is a ticket for this already but I can't find it. It appears that there is a bad patch file for doxygen.

$ sudo port sync && sudo port clean doxygen && sudo port -u upgrade doxygen
--->  Cleaning doxygen
--->  Fetching doxygen
--->  Verifying checksum(s) for doxygen
--->  Extracting doxygen
--->  Applying patches to doxygen
Error: Target org.macports.patch returned: shell command " cd "/opt/local/var/ma
cports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_te
xtproc_doxygen/work/doxygen-1.5.9" && patch -p0 < '/opt/local/var/macports/sourc
es/rsync.macports.org/release/ports/textproc/doxygen/files/patch-portable.cpp.di
ff'" returned error 1
Command output: patching file src/portable.cpp
Hunk #1 FAILED at 380.
1 out of 1 hunk FAILED -- saving rejects to file src/portable.cpp.rej
 
Error: Unable to upgrade port: 1
$

Attachments

patch-doxygen.diff (1.2 KB) - added by devans@… 4 years ago.
Proposed patch for Portfile

Change History

comment:1 Changed 4 years ago by blb@…

  • Owner changed from macports-tickets@… to css@…
  • Cc css@… removed

Looks like a patch only applied on < 10.5 versions, so I'm guessing Chris tested on 10.5. Looks like they changed the way they handle libiconv so that patch may no longer be needed.

comment:2 Changed 4 years ago by toby@…

  • Summary changed from Doxygen @ 1.5.9 - Patch Fails to Doxygen @ 1.5.9 - Patch Fails on Tiger

comment:3 Changed 4 years ago by toby@…

  • Priority changed from High to Normal

comment:4 Changed 4 years ago by css@…

  • Status changed from new to assigned

I don't have a tiger system on which to test, although maybe I could set one up on an external drive.

comment:5 Changed 4 years ago by devans@…

On 10.4.11 ppc, I ran into the same problem. The patch for os < 9 seems to no longer be necessary -- nothing in the target file that is similar to the lines trying to be patched.

In addition, the addition of configure.ldflags via reinplace causes link failures. The port trys to link against the Macports libmd5 instead of the one embedded in the program.

Have attached a patch for the Portfile that allows the port to build and install properly (for me at least).

Hope this helps.

Changed 4 years ago by devans@…

Proposed patch for Portfile

comment:6 Changed 4 years ago by css@…

Thanks for the patch! I'll run a quick test on Leopard, but it looks like this should be a simple fix. Thanks!

comment:7 Changed 4 years ago by css@…

Committed to r53590. If you can verify that the current committed Portfile works, then this ticket may be closed.

comment:8 follow-up: ↓ 9 Changed 4 years ago by devans@…

Just rebuildt doxygen successfully using the newly committed Portfile but it would be nice to hear from the ticket reporter as well.

comment:9 in reply to: ↑ 8 Changed 4 years ago by css@…

  • Status changed from assigned to closed
  • Resolution set to fixed

Replying to devans@…:

Just rebuildt doxygen successfully using the newly committed Portfile but it would be nice to hear from the ticket reporter as well.

Considering this ticket closed unless there's followup indicating that the current port fails on Tiger.

Note: See TracTickets for help on using tickets.