New Ticket     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #20135 (closed update: fixed)

Opened 3 years ago

Last modified 3 years ago

file-4.26: update to 5.03

Reported by: boeyms@… Owned by: snc@…
Priority: Normal Milestone:
Component: ports Version: 1.7.1
Keywords: Cc: jay-macports@…
Port: file

Description

file has been updated to version 5.03; attached is a Portfile patch to perform this update. It performs the following:

  • updates the version and revision numbers;
  • updates the checksums;
  • updates the homepage; and
  • removes patch-src-file.h.diff since it has been incorporated into file-5.03.

Additionally, have the other three patches in the files directory (patch-lzma.diff, patch-magic-Magdir-msdos.diff and patch-magic-Makefile.in.diff) been submitted upstream? If not, they might like to hear about them.

Attachments

file_4.26_to_5.03.diff Download (2.2 KB) - added by boeyms@… 3 years ago.

Change History

Changed 3 years ago by boeyms@…

  Changed 3 years ago by toby@…

Can we also reconsider the bizarre "--program-prefix=g" option? I don't really understand what that's supposed to accomplish. :(

  Changed 3 years ago by blb@…

I'm guessing it's similar to the same idea with coreutils etc, though file isn't gnu so that doesn't make sense; I don't see having file in ${prefix}/bin overriding the one in /usr/bin as being anywhere near as dangerous as what coreutils provides...

  Changed 3 years ago by toby@…

The only real difference is that /usr/bin/file handles universal binaries to some extent.

follow-up: ↓ 8   Changed 3 years ago by jay-macports@…

I'm not a big fan of the program-prefix either, but I'm not sure what the MacPorts rules are for when it's OK to override a built-in binary. Anyone know?

As for the patches - I remember thinking that I should do that when I took over the port, but I have no evidence that I actually did it. I have a vague recollection of deciding that some or all were obsolete. I'll take a closer look this weekend, and get these patches pushed. I think the lzma patch was for a "future" file format that never actually made it into the wild...

  Changed 3 years ago by snc@…

  • owner changed from jay-macports@… to snc@…
  • cc jay-macports@… added
  • status changed from new to assigned

It seems that LZMA support is already added, which is handled by patch-lzma.diff

  Changed 3 years ago by snc@…

  • status changed from assigned to closed
  • resolution set to fixed

Committed in r54772. Also removed LZMA patch. Timeout.

  Changed 3 years ago by snc@…

I also went with Toby's advice that the program-prefix be dropped. I further added a note to the port description indicating that the missing functionality can be achieved via otool.

in reply to: ↑ 4   Changed 3 years ago by afb@…

Replying to jay-macports@…:

I think the lzma patch was for a "future" file format that never actually made it into the wild...

The lzma patch was added upstream, just that "new LZMA" was renamed to XZ. See  http://tukaani.org/xz/

Note: See TracTickets for help on using tickets.