Opened 14 years ago

Closed 14 years ago

#22336 closed submission (fixed)

kipi-plugins 0.7.0 Submission of portfile

Reported by: jgosmann (Jan Gosmann) Owned by: mf2k (Frank Schima)
Priority: Normal Milestone:
Component: ports Version:
Keywords: digikam, kde, image manipulation Cc: smgava@…
Port: kipi-plugins

Description

I've created a portfile for kipi-plugins (http://www.digikam.org/drupal/node/481).

Acquireimages is excluded from build, because it does not build. Also is RemoveRedEyes excluded from build, because the one port needed as dependeny for this plugin does not build on Snow Leopard (I think it was opencv).

Attachments (3)

patch-CMakeLists.txt.diff (456 bytes) - added by jgosmann (Jan Gosmann) 14 years ago.
Patch needed for the kipi-plugins port.
Portfile (1.5 KB) - added by jgosmann (Jan Gosmann) 14 years ago.
Updated portfile (kipi-plugins 0.8.0)
patch-CMakeLists.txt.2.diff (456 bytes) - added by jgosmann (Jan Gosmann) 14 years ago.
Updated patch for kipi-plugins 0.8.0

Download all attachments as: .zip

Change History (11)

Changed 14 years ago by jgosmann (Jan Gosmann)

Attachment: patch-CMakeLists.txt.diff added

Patch needed for the kipi-plugins port.

comment:1 Changed 14 years ago by jgosmann (Jan Gosmann)

Cc: jan@… added

Cc Me!

comment:2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Your variants need to do more than remove dependencies -- they also need to add configure arguments, environment variables, or patches that ensure the software will not use those dependencies even if they're already installed.

Our convention for naming "no" variants is to use underscores, e.g. "no_mesa", instead of "nomesa".

I think the line "distname kipi-plugins-${version}" is unnecessary because that should already be the default.

comment:3 Changed 14 years ago by jgosmann (Jan Gosmann)

You're right that the variants should ensure that the dependencies do not get used. However, as far as I know there is no possibility to ensure this in the CMake build process of the KDE programs except patching the CMakeLists.txt file itself. Therefore I removed these variants.

I would suggest to include the naming convention for "no" variants in the documentation (http://guide.macports.org/#development.variants). Or have I overlooked it?

The distname line might be unnecessary, but I did not test it. Does it any harm?

I will attach a new Portfile and patch file with the changes described. Moreover this portfile is now for kipi-plugins version 0.8.0 which got released some days ago.

Changed 14 years ago by jgosmann (Jan Gosmann)

Attachment: Portfile added

Updated portfile (kipi-plugins 0.8.0)

Changed 14 years ago by jgosmann (Jan Gosmann)

Attachment: patch-CMakeLists.txt.2.diff added

Updated patch for kipi-plugins 0.8.0

comment:4 Changed 14 years ago by smgava@…

Cc: smgava@… added

Cc Me!

comment:5 Changed 14 years ago by mf2k (Frank Schima)

Cc: jan@… removed
Keywords: kipi-plugins removed
Version: 1.8.1

comment:6 Changed 14 years ago by mf2k (Frank Schima)

I see the following error when I tried to install this:

--->  Fetching kipi-plugins
--->  Attempting to fetch kipi-plugins-0.8.0.tar.bz2 from http://downloads.sourceforge.net/kipi
--->  Verifying checksum(s) for kipi-plugins
--->  Extracting kipi-plugins
--->  Applying patches to kipi-plugins
Error: Target org.macports.patch returned: shell command " cd "/opt/local/var/macports/build/_opt_mports_trunk_dports_kde_kipi-plugins/work/build" && /usr/bin/patch -p0 < '/opt/mports/trunk/dports/kde/kipi-plugins/files/patch-CMakeLists.txt.diff'" returned error 1
Command output: can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- ../kipi-plugins-0.7.0/CMakeLists.txt.orig	2009-10-29 17:18:40.000000000 +0100
|+++ ../kipi-plugins-0.7.0/CMakeLists.txt	2009-10-29 17:19:21.000000000 +0100
--------------------------
File to patch: 
Skip this patch? [y] 
Skipping patch.
1 out of 1 hunk ignored

Error: Status 1 encountered during processing.

comment:7 Changed 14 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to macsforever2000@…
Status: newassigned

Nevermind, my bad.

comment:8 Changed 14 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: assignedclosed

r60868. Thanks for the submission!

Note: See TracTickets for help on using tickets.