Opened 14 years ago

Closed 13 years ago

#22495 closed defect (fixed)

rsync @3.0.7 does not preserve creation date when built for 64-bit

Reported by: philipp@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.8.1
Keywords: LP64 Cc: 858wildcat@…, faisal.moledina@…
Port: rsync

Description

Discovered with backup bouncer that creation times are not preserved using the latest rsync 3.0.6 from macports.

Used rsync options: -aNHAXxv --fileflags --force-change --delete --delete-excluded

Output below is directly from backup bouncer:

------------------ rsync-macports ------------------
Verifying:    basic-permissions ... ok (Critical)
Verifying:           timestamps ... ok (Critical)
Verifying:             symlinks ... ok (Critical)
Verifying:    symlink-ownership ... ok 
Verifying:            hardlinks ... ok (Important)
Verifying:       resource-forks ... 
   Sub-test:             on files ... ok (Critical)
   Sub-test:  on hardlinked files ... ok (Important)
Verifying:         finder-flags ... ok (Critical)
Verifying:         finder-locks ... ok 
Verifying:        creation-date ... FAIL 
Verifying:            bsd-flags ... ok 
Verifying:       extended-attrs ... 
   Sub-test:             on files ... ok (Important)
   Sub-test:       on directories ... ok (Important)
   Sub-test:          on symlinks ... ok 
Verifying: access-control-lists ... 
   Sub-test:             on files ... ok (Important)
   Sub-test:              on dirs ... ok (Important)
Verifying:                 fifo ... ok 
Verifying:              devices ... ok 
Verifying:          combo-tests ... 
   Sub-test:  xattrs + rsrc forks ... ok 
   Sub-test:     lots of metadata ... ok 

Change History (11)

comment:1 Changed 14 years ago by philipp@…

Cc: philipp@… added

Cc Me!

comment:2 Changed 14 years ago by mf2k (Frank Schima)

Cc: philipp@… removed
Owner: changed from macports-tickets@… to simon@…
Port: rsync added; rsync-3.0.6 removed

comment:3 Changed 14 years ago by nerdling (Jeremy Lavergne)

This appears to be a known bug upstream.

comment:4 Changed 14 years ago by nerdling (Jeremy Lavergne)

Their conclusion:

crtimes patch does not work when rsync 3.0.6-pre1 (and 3.0.5) is compiled for x86_64 and run on Core2Duo in 64bit mode on Mac OS X 10.5.6. crtimes patch does only work when rsync is compiled in 32bit mode (i386) or for any PPC build.

The maintainer might consider enabling build_arch=i386 for this port if os.major > 9.

comment:5 Changed 14 years ago by 858wildcat@…

Cc: 858wildcat@… added

Cc Me!

comment:6 Changed 14 years ago by macports@…

https://bugzilla.samba.org/show_bug.cgi?id=6276

A fix was created for this. I had to apply it to 3.0.7 as well.

comment:7 Changed 14 years ago by simon@…

Owner: changed from simon@… to macports-tickets@…

comment:8 Changed 14 years ago by faisal.moledina@…

I just verified with backup bouncer 0.2.0 that creation times with rsync 3.0.7 are not preserved without the 64-bit patch from the rsync Bugzilla. What is the status of including this in the portfile? Using instructions at the Bombich site, I downloaded the patch using

curl -o files/patch-crtimes-64bit.diff https://bugzilla.samba.org/attachment.cgi?id=5288

in my local dports/net/rsync dir. I added it to the Portfile in the patchfiles section and it built successfully and the resulting rsync preserved creation times, along with everything else.

comment:9 Changed 14 years ago by faisal.moledina@…

Cc: faisal.moledina@… added

Cc Me!

comment:10 Changed 13 years ago by jmroot (Joshua Root)

Keywords: LP64 added
Summary: rsync-3.0.6 does not preserve creation datersync @3.0.7 does not preserve creation date when built for 64-bit

comment:11 Changed 13 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.