pidgin +quartz fails during patch phase

[senz@…]

--->  Fetching pidgin
--->  Attempting to fetch pidgin-2.6.2.tar.bz2 from http://arn.se.distfiles.macports.org/pidgin
--->  Verifying checksum(s) for pidgin
--->  Extracting pidgin
--->  Applying patches to pidgin
Error: reinplace: couldn't read file "intltool-merge.in": no such file or directory
Error: Target org.macports.patch returned: reinplace sed(1) failed
Error: Status 1 encountered during processing.

[jmr@…]

2.6.3 is the current version, but this may well still happen if you are using +quartz (which, if you are, you really should have mentioned).

[senz@…]

Replying to jmr@…:

2.6.3 is the current version, but this may well still happen if you are using +quartz (which, if you are, you really should have mentioned).

Sorry, i forgot to mention it. Options are: +no_x11+quartz

[ryandesign@…]

Two problems in the +quartz variant's post-patch block:

    post-patch {
        reinplace "s|@INTLTOOL_ICONV@|${prefix}/bin/iconv|g" intltool-merge.in
        system "${filespath}/autogen.sh"
    }

1. The reinplace assumes we're in ${worksrcpath}. Ports were never meant to assume that was the case, but many did. As of MacPorts 1.8.0 this is no longer true, so it now fails to find the to-be-reinplaced file. But more importantly, the file does not contain the to-be-replaced string. (The file is totally empty.) The reinplace can just be removed completely.
2. The autogen.sh invocation also assumes we're in ${worksrcpath}. Since we're not, it should cd to ${worksrcpath} first.

[ryandesign@…]

Fixed in r60456.