Ticket #22977 (reopened enhancement)
postgresql8x/9x should have tablefunc variant
| Reported by: | russm-trac-macports-org@… | Owned by: | mww@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | jwa@…, chepra@…, dh@…, dark.panda+macports@…, nonstop.server@… |
| Port: | postgresql80 postgresql81 postgresql82 postgresql83 postgresql84 postgresql90 postgresql91 postgresql-devel |
Description
postgresql should either build more of the contrib section, or allow the contrib items that are not in the default build to be selected as variants. the attached patch adds a "tablefunc" variant that adds that contrib item to the build.
Attachments
Change History
Changed 3 years ago by russm-trac-macports-org@…
- Attachment portfile-tablefunc-variant.diff added
comment:1 Changed 3 years ago by macsforever2000@…
- Cc jwa@… added
- Keywords haspatch added
- Version 1.8.1 deleted
- Owner changed from macports-tickets@… to mww@…
comment:3 Changed 2 years ago by dh@…
- Port changed from postgresql85 postgresql84 to postgresql85 postgresql84 postgresql90
Wondering where this ticket stands? Currently postgresql9x ports also only install a subset of the contrib modules. It would be great to add tablefunc either to that default set or as a variant.
comment:4 Changed 2 years ago by jmr@…
- Cc chepra@… added
- Port changed from postgresql85 postgresql84 postgresql90 to postgresql80 postgresql81 postgresql82 postgresql83 postgresql84 postgresql90 postgresql91 postgresql-devel
- Summary changed from postgresql8x should have tablefunc variant to postgresql8x/9x should have tablefunc variant
comment:5 Changed 12 months ago by jea@…
Can't someone do this? Is there a way to parameterize the contrib line? I'm pretty new at this but if anyone would point me in the right direction I could take a stab at it.
Should it be a variant for each contrib?
What I've done is make my own Portfile and add tablefunc to the end of the contribs line:
- set contribs "adminpack dblink fuzzystrmatch lo uuid-ossp pg_buffercache pg_trgm pgcrypto tsearch2 vacuumlo xml2"
+ set contribs "adminpack dblink fuzzystrmatch lo uuid-ossp pg_buffercache pg_trgm pgcrypto tsearch2 vacuumlo xml2 tablefunc"
comment:6 Changed 11 months ago by dh@…
I've added the patch I've been using the last couple of years for postgres 8x/9x. It adds a variant per extension which is not necessarily the best approach, but at least it solves the problem.
comment:7 Changed 11 months ago by jwa@…
- Status changed from new to closed
- Resolution set to fixed
Now the port installs most of the contribs, incl. tablefunc, but if some extension is missing, let me know
comment:8 Changed 10 months ago by dh@…
- Status changed from closed to reopened
- Resolution fixed deleted
Its missing most of the extensions I had as variants in the patch I attached earlier, eg hstore, btree_gist, ltree, citext. Can these either be added to the contribs line, or variants added as per that patch?
comment:9 Changed 8 months ago by dark.panda+macports@…
Attached are versions of the postgresql92, postgresql91 and postgresql90 Portfiles that build all available modules in the contrib directory via a blacklist of modules rather than the current whitelist system that's used.
Changed 8 months ago by dark.panda+macports@…
- Attachment Portfile-postgresql90 added
PostgreSQL 9.0 Portfile with contrib module whitelist
Changed 8 months ago by dark.panda+macports@…
- Attachment Portfile-postgresql91 added
PostgreSQL 9.1 Portfile with contrib module whitelist
Changed 8 months ago by dark.panda+macports@…
- Attachment Portfile-postgresql92 added
PostgreSQL 9.2 Portfile with contrib module whitelist
add "tablefunc" variant to postgresql84 and postgresql85 Portfiles