New Ticket     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #23511 (closed defect: fixed)

Opened 2 years ago

Last modified 23 months ago

git-core: gitweb variant missing gitweb.js

Reported by: garnier@… Owned by: ryandesign@…
Priority: Normal Milestone:
Component: ports Version: 1.8.2
Keywords: haspatch Cc: maccheck@…, bryan@…
Port: git-core

Description (last modified by jmr@…) (diff)

At some point, gitweb added a gitweb.js for client side enhancements... The server complains the file is missing. Simple one line add of "gitweb.js" to the portfile.

--- Portfile.old	2010-02-01 13:19:26.000000000 -0500
+++ Portfile	2010-02-01 13:26:40.000000000 -0500
@@ -106,6 +106,7 @@
         xinstall -m 444 -W ${worksrcpath}/gitweb \
             gitweb.cgi \
             gitweb.css \
+            gitweb.js \
             git-favicon.png \
             git-logo.png \
             ${destroot}${prefix}/share/${name}/gitweb

Attachments

git-core.patch Download (434 bytes) - added by garnier@… 2 years ago.
patch file for git-core/Portfile

Change History

Changed 2 years ago by garnier@…

patch file for git-core/Portfile

Changed 2 years ago by jmr@…

  • owner changed from macports-tickets@… to bryan@…
  • cc maccheck@… added
  • description modified (diff)
  • keywords haspatch added
  • port set to git-core

Please remember to preview and use WikiFormatting, fill in the Port field, and cc the maintainers.

Changed 2 years ago by garnier@…

  • cc garnier@… added

Cc Me!

Changed 2 years ago by garnier@…

Oh... and while you are at it.. you may consider making gitweb.cgi executable by _www... since it needs this to run, at least when using with Apache

Changed 2 years ago by maccheck@…

I integrated your patch into the new Portfile version for git-core 1.6.6.2 (see #23666). I'm currently hesitant to update the executable bits of the installed files because I don't know the MacPorts policy for that.

For the time being I would like to stick to manually updating it by the user who needs it...

Changed 2 years ago by maccheck@…

Sorry, as #23666 was superseded by r63775 the gitweb.js patch was not included in the last git-core update.

Changed 23 months ago by ryandesign@…

  • owner changed from bryan@… to ryandesign@…
  • status changed from new to assigned
  • cc bryan@… added; garnier@… removed
  • summary changed from git-core 1.6.6.1 - gitweb varient missing gitweb.js to git-core: gitweb variant missing gitweb.js

Changed 23 months ago by ryandesign@…

  • status changed from assigned to closed
  • resolution set to fixed

I agree gitweb.cgi should have the executable bit. That's fixed, and gitweb.js is now being installed, as part of r65174.

Note: See TracTickets for help on using tickets.