root afs variant declares dependency on nonexistent krbafsv port

[ryandesign@…]

root's afs variant declares a dependency on the port krbafsv, but no such port exists.

$ port lint root +afs
--->  Verifying Portfile for root
Error: Unknown dependency: krbafsv
--->  1 errors and 0 warnings found.

[ryandesign@…]

I see there is a port krbafs. Is that what you meant? It seems to be ancient software; I can't get it to build on Snow Leopard.

[mattiafrancescomoro@…]

Yes i refear to this port: krbafs

[ryandesign@…]

Ok, but if I change the dependency in root's afs variant to krbafs, it doesn't build with afs support. The configure script says:

Checking for shared AFS libs:
Checking for libafsrpc ... no
Checking for static AFS libs:
Checking for libafsrpc ... no

The krbafs port provides a libkrbafs.dylib, not a libafsrpc.dylib. libafsrpc seems to be a part of ​openafs. Should we add a port for openafs and make root use that? or delete the afs variant from the root port? or do something else?

[mattiafrancescomoro@…]

i remove the afs support for root

can i update directly the portfile or i have to submit every modification via tickets?

[raimue@…]

Replying to mattiafrancescomoro@…: As described in ​the guide, please file tickets with your changes, preferably as unified diff. It's fine if you attach it to this ticket, do not open another one.

[ryandesign@…]

I'm not going to commit the attached Portfile because it is not based on the latest version. Please supply a diff of the changes you actually want us to make.

[mattiafrancescomoro@…]

This is the diff file from the latest version, i added also the support for pythia

[mattiafrancescomoro@…]

this is the diff file...

[mattiafrancescomoro@…]

This is the pythia portfile #24613

[ryandesign@…]

Your diff suggests lots of changes which have nothing to do with this ticket. You suggested removing the afs variant entirely; I've done this in r66959. This resolves the issue reported in this ticket. You also provided a pythia variant; I've added this in r66962. You also suggested removing an errant backslash in the fftw3 variant; I removed this and another errant backslash in r66963.

For any remaining changes, please file additional tickets, and make sure the diffs you provide only make the changes that are relevant to resolve the issue.