VLC, VLC09 fail to build with zlib 1.2.4

[ryandesign (Ryan Carsten Schmidt)]

VLC fails to build with zlib 1.2.4 (on Snow Leopard):

libtool: compile:  /Developer/usr/llvm-gcc-4.2/bin/llvm-gcc-4.2 -std=gnu99 -isysroot /Developer/SDKs/MacOSX10.5.sdk -mmacosx-version-min=10.5 -DHAVE_CONFIG_H -I. -I../../.. -I../../../include -I../../../include -I/opt/local/include -DSYS_DARWIN -I/opt/local/include -D_FILE_OFFSET_BITS=64 -D__USE_UNIX98 -D_LARGEFILE64_SOURCE -D_REENTRANT -D_THREAD_SAFE -DHAVE_RELEASE -D__LIBVLC__ -D__PLUGIN__ -DMODULE_NAME=zip -DMODULE_NAME_IS_zip -DMODULE_STRING=\"zip\" -O4 -ffast-math -funroll-loops -fno-omit-frame-pointer -I../../../libs/unzip -O2 -arch x86_64 -D_INTL_REDIRECT_MACROS -DMACOSX_DEPLOYMENT_TARGET=10.5 -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wcast-align -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -MT libzip_plugin_la-zipstream.lo -MD -MP -MF .deps/libzip_plugin_la-zipstream.Tpo -c zipstream.c  -fno-common -DPIC -o .libs/libzip_plugin_la-zipstream.o
In file included from ../../../libs/unzip/unzip.h:53,
                 from zip.h:38,
                 from zipstream.c:32:
/opt/local/include/zlib.h:1561: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gzseek64'
/opt/local/include/zlib.h:1562: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gztell64'
/opt/local/include/zlib.h:1563: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gzoffset64'
/opt/local/include/zlib.h:1564: error: expected declaration specifiers or '...' before 'off64_t'
/opt/local/include/zlib.h:1565: error: expected declaration specifiers or '...' before 'off64_t'
zipstream.c: In function 'Control':
zipstream.c:309: warning: comparison between signed and unsigned
zipstream.c: In function 'ZipIO_Write':
zipstream.c:833: warning: unused variable 'ERROR_zip_cannot_write_this_should_not_happen'
make[6]: *** [libzip_plugin_la-zipstream.lo] Error 1
make[5]: *** [all] Error 2
make[4]: *** [all-recursive] Error 1
make[3]: *** [all] Error 2
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

VLC09 fails like this (on Tiger):

libtool: compile:  /usr/bin/gcc-4.0 -std=gnu99 -mmacosx-version-min=10.4 -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../../include -I/opt/local/include -DSYS_DARWIN -I/opt/local/include -D_FILE_OFFSET_BITS=64 -D__USE_UNIX98 -D_LARGEFILE64_SOURCE -D_REENTRANT -D_THREAD_SAFE -DHAVE_RELEASE -D__LIBVLC__ -D__PLUGIN__ -DMODULE_NAME=access_http -DMODULE_NAME_IS_access_http -DMODULE_STRING=\"access_http\" -O3 -ffast-math -funroll-loops -march=pentium-m -mtune=prescott -fno-omit-frame-pointer -O2 -arch i386 -D_INTL_REDIRECT_MACROS -DMACOSX_DEPLOYMENT_TARGET=10.4 -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wcast-align -Wwrite-strings -Wmissing-prototypes -MT libaccess_http_plugin_la-http.lo -MD -MP -MF .deps/libaccess_http_plugin_la-http.Tpo -c http.c  -fno-common -DPIC -o .libs/libaccess_http_plugin_la-http.o
In file included from http.c:51:
/opt/local/include/zlib.h:1561: error: parse error before 'gzseek64'
/opt/local/include/zlib.h:1561: error: parse error before 'off64_t'
/opt/local/include/zlib.h:1561: warning: type defaults to 'int' in declaration of 'gzseek64'
/opt/local/include/zlib.h:1561: warning: data definition has no type or storage class
/opt/local/include/zlib.h:1562: error: parse error before 'gztell64'
/opt/local/include/zlib.h:1562: warning: type defaults to 'int' in declaration of 'gztell64'
/opt/local/include/zlib.h:1562: warning: data definition has no type or storage class
/opt/local/include/zlib.h:1563: error: parse error before 'gzoffset64'
/opt/local/include/zlib.h:1563: warning: type defaults to 'int' in declaration of 'gzoffset64'
/opt/local/include/zlib.h:1563: warning: data definition has no type or storage class
/opt/local/include/zlib.h:1564: error: parse error before 'off64_t'
/opt/local/include/zlib.h:1565: error: parse error before 'off64_t'
make[5]: *** [libaccess_http_plugin_la-http.lo] Error 1
make[4]: *** [all-recursive] Error 1
make[3]: *** [all] Error 2
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

#24067 is the general ticket for this zlib 1.2.4 issue but my understanding is that this reveals a bug in VLC/VLC09 and it is thus in these ports that the problem must be fixed.

[gellule.xg@…]

Submitted a ticket on VLC's bug tracker: ​https://trac.videolan.org/vlc/ticket/3452

[gellule.xg@…]

A fix made it to VLC's git master: ​http://git.videolan.org/gitweb.cgi?p=vlc.git;a=commit;h=52ce2e5ff8859fcd52c49b4fb8bc8ef1ff4210e0 It should be in there next release.

[raimue (Rainer Müller)]

I guess this should no longer be a problem with zlib @1.2.5. Works for me.