New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #24127 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

libproxy 0.4.0_0 build failure on Leopard: JavaScriptCore/JavaScript.h: No such file or directory

Reported by: michael.g.ross.98@… Owned by: devans@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: nox@…, mike@…, guy.linton@…, pohart@…, thedoobs@…, ryandesign@…
Port: libproxy

Description (last modified by ryandesign@…) (diff)

Upgrading from libproxy 0.3.0_1 fails on Mac OS X 10.5.8.

cm019-b52:~ mgross$ sudo port outdated
The following installed ports are outdated:
libproxy                       0.3.0_1 < 0.4.0_0         
librsvg                        2.26.0_1 < 2.26.0_2       
mysql5                         5.1.44_0 < 5.1.45_0       
cm019-b52:~ mgross$ sudo port upgrade outdated
--->  Computing dependencies for libproxy
--->  Building libproxy
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0" && /usr/bin/make -j1 all " returned error 2
Command output: /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:124: error: 'JSCheckScriptSyntax' was not declared in this scope
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:125: error: 'class webkit_pacrunner' has no member named 'jsctx'
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:131: error: 'class webkit_pacrunner' has no member named 'jsctx'
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:132: error: 'class webkit_pacrunner' has no member named 'jsctx'
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:132: error: 'JSGarbageCollect' was not declared in this scope
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:133: error: 'class webkit_pacrunner' has no member named 'jsctx'
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:133: error: 'JSGlobalContextRelease' was not declared in this scope
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp: In member function 'virtual std::string webkit_pacrunner::run(const libproxy::url&)':
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:139: error: 'JSStringRef' was not declared in this scope
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:139: error: expected `;' before 'str'
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:140: error: 'JSValueRef' was not declared in this scope
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:140: error: expected `;' before 'val'
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:145: error: 'str' was not declared in this scope
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:145: error: 'JSStringCreateWithUTF8CString' was not declared in this scope
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:146: error: 'class webkit_pacrunner' has no member named 'jsctx'
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:146: error: 'JSCheckScriptSyntax' was not declared in this scope
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:147: error: 'val' was not declared in this scope
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:147: error: 'class webkit_pacrunner' has no member named 'jsctx'
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:147: error: 'JSEvaluateScript' was not declared in this scope
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:148: error: 'class webkit_pacrunner' has no member named 'jsctx'
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:148: error: 'val' was not declared in this scope
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:148: error: 'JSValueIsString' was not declared in this scope
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:149: error: 'JSStringRelease' was not declared in this scope
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:152: error: 'class webkit_pacrunner' has no member named 'jsctx'
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:152: error: 'val' was not declared in this scope
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:152: error: 'JSValueToStringCopy' was not declared in this scope
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/pacrunner_webkit.cpp:152: error: 'jstr2str' cannot be used as a function
make[2]: *** [libproxy/CMakeFiles/libproxy.dir/modules/pacrunner_webkit.cpp.o] Error 1
make[1]: *** [libproxy/CMakeFiles/libproxy.dir/all] Error 2
make: *** [all] Error 2

Attachments

mypatch.diff (1.7 KB) - added by elelay@… 4 years ago.
diff against r67119

Change History

comment:1 Changed 4 years ago by ryandesign@…

  • Owner changed from macports-tickets@… to devans@…
  • Description modified (diff)

Don't forget WikiFormatting, please.

comment:2 Changed 4 years ago by jmr@…

  • Cc nox@… added

comment:3 Changed 4 years ago by mike@…

When I try to build libproxy on Mac OS X 10.6.2, I get:

cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy && /usr/bin/g++-4.2   -Dconfig_gnome_EXPORTS -D_POSIX_C_SOURCE=1 -DLIBEXECDIR=\"/opt/local/libexec/\" -arch x86_64 -isysroot /Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -g -Wall -Werror -fvisibility=hidden -O2 -arch x86_64  -O3 -DNDEBUG -fPIC -I/opt/local/include -I/opt/local/include/gconf/2 -I/opt/local/include/orbit-2.0 -I/opt/local/include/dbus-1.0 -I/opt/local/lib/dbus-1.0/include -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/..   -o CMakeFiles/config_gnome.dir/modules/config_gnome.cpp.o -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/config_gnome.cpp
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/config_gnome.cpp: In constructor 'gnome_config_extension::gnome_config_extension()':
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_libproxy/work/libproxy-0.4.0/libproxy/modules/config_gnome.cpp:117: error: 'FNONBLOCK' was not declared in this scope
make[2]: *** [libproxy/CMakeFiles/config_gnome.dir/modules/config_gnome.cpp.o] Error 1
make[1]: *** [libproxy/CMakeFiles/config_gnome.dir/all] Error 2
make: *** [all] Error 2

comment:4 Changed 4 years ago by mike@…

  • Cc mike@… added

Cc Me!

comment:5 Changed 4 years ago by todmorrison@…

As far as I can tell 'FNONBLOCK' in config_gnome.cpp should be 'O_NONBLOCK'. Changing this will get it to compile, but I haven't thoroughly tested it...

comment:7 follow-up: ↓ 8 Changed 4 years ago by guy.linton@…

  • Cc guy.linton@… added

Cc Me!

comment:8 in reply to: ↑ 7 Changed 4 years ago by guy.linton@…

It looks as though there may be different errors on different versions of Mac OS X. I am on 10.4.11, variant no_x11, and get the same errors as the OP (JSCheckScriptSyntax not declared in this scope etc. etc., not the errors in 10.6.2). Changing FNONBLOCK in config_gnome.cpp has no effect (the JSCheckScriptSyntax etc errors still occur).

libproxy @0.3.0_1 worked fine for me a few days ago (though possibly with a different variant at that time)

comment:9 Changed 4 years ago by nox@…

Guy, please open a new ticket to report this different problem.

comment:10 Changed 4 years ago by nox@…

  • Version 1.8.2 deleted

Mmh, I meant Mike, not Guy. And the other ticket already exists, it's #24117.

comment:11 Changed 4 years ago by pohart@…

This appears to be fixed upstream It looks like we need r608 and r616.

Incidentally, this is also the upstream fix for #24117

comment:12 Changed 4 years ago by pohart@…

  • Cc pohart@… added

Cc Me!

comment:13 Changed 4 years ago by thedoobs@…

  • Cc thedoobs@… added

Cc Me!

comment:14 Changed 4 years ago by ryandesign@…

  • Status changed from new to closed
  • Cc ryandesign@… added
  • Resolution set to fixed
  • Summary changed from libproxy 0.4.0_0 build failure to libproxy 0.4.0_0 build failure on Leopard: JavaScriptCore/JavaScript.h: No such file or directory

"'FNONBLOCK' was not declared in this scope" was dealt with in #24117 by changing FNONBLOCK to O_NONBLOCK.

"JavaScriptCore/JavaScript.h: No such file or directory" was fixed just now in r65622 using upstream commits r608 and r616 as suggested above, which checks for and uses JavaScriptCore.h on Mac OS X instead of JavaScript.h -- fixed for Leopard, that is; Snow Leopard never saw this error because it has both JavaScript.h and JavaScriptCore.h, and Tiger is still not fixed because it has neither JavaScript.h nor JavaScriptCore.h; I reported this upstream.

Changed 4 years ago by elelay@…

diff against r67119

comment:15 follow-up: ↓ 16 Changed 4 years ago by elelay@…

  • Status changed from closed to reopened
  • Resolution fixed deleted

seems like there is no hope for Tiger (quoting from upstream ticket)

I'm rejecting this issue unless someone can come up with the proper headers on older 
OS X versions.

Couldn't the Webkit pacrunner be disabled on this platform ? Please find attached a patch doing that...

comment:16 in reply to: ↑ 15 Changed 4 years ago by elelay@…

committed in r67390

comment:17 Changed 4 years ago by elelay@…

  • Status changed from reopened to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.