htop requires libtool

[xindigo@…]

htop depends on libtool, but the portfile does not have libtool as a dependency for it.

[ryandesign@…]

That patch is not how you would add a libtool dependency.

What problem do you encounter when libtool is not installed? htop builds fine for me whether or not libtool is installed. If you get an error, please supply your complete debug build log.

[xindigo@…]

You're right; it isn't libtool that is a dependency, but automake, which was installed when I installed libtool in order to fix the problem. Here is my debug log when automake is not installed:

--->  Configuring htop
DEBUG: Using compiler 'Mac OS X gcc 4.0'
DEBUG: Executing proc-pre-org.macports.configure-configure-0
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works, ...): suspicious cache-id, must contain _cv_ to be cached
../../lib/autoconf/general.m4:1998: AC_CACHE_VAL is expanded from...
../../lib/autoconf/general.m4:2019: AC_CACHE_CHECK is expanded from...
aclocal.m4:1388: AC_LIBTOOL_LINKER_OPTION is expanded from...
aclocal.m4:3234: _LT_AC_LANG_C_CONFIG is expanded from...
aclocal.m4:3233: AC_LIBTOOL_LANG_C_CONFIG is expanded from...
aclocal.m4:872: AC_LIBTOOL_SETUP is expanded from...
aclocal.m4:852: _AC_PROG_LIBTOOL is expanded from...
aclocal.m4:817: AC_PROG_LIBTOOL is expanded from...
configure.ac:17: the top level
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works, ...): suspicious cache-id, must contain _cv_ to be cached
aclocal.m4:1346: AC_LIBTOOL_COMPILER_OPTION is expanded from...
aclocal.m4:5280: AC_LIBTOOL_PROG_COMPILER_PIC is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_CXX, ...): suspicious cache-id, must contain _cv_ to be cached
aclocal.m4:3380: _LT_AC_LANG_CXX_CONFIG is expanded from...
aclocal.m4:3379: AC_LIBTOOL_LANG_CXX_CONFIG is expanded from...
aclocal.m4:2378: _LT_AC_TAGCONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_F77, ...): suspicious cache-id, must contain _cv_ to be cached
aclocal.m4:4407: _LT_AC_LANG_F77_CONFIG is expanded from...
aclocal.m4:4406: AC_LIBTOOL_LANG_F77_CONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_GCJ, ...): suspicious cache-id, must contain _cv_ to be cached
aclocal.m4:4506: _LT_AC_LANG_GCJ_CONFIG is expanded from...
aclocal.m4:4505: AC_LIBTOOL_LANG_GCJ_CONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_static_works, ...): suspicious cache-id, must contain _cv_ to be cached
../../lib/autoconf/general.m4:1998: AC_CACHE_VAL is expanded from...
../../lib/autoconf/general.m4:2019: AC_CACHE_CHECK is expanded from...
aclocal.m4:1388: AC_LIBTOOL_LINKER_OPTION is expanded from...
aclocal.m4:3234: _LT_AC_LANG_C_CONFIG is expanded from...
aclocal.m4:3233: AC_LIBTOOL_LANG_C_CONFIG is expanded from...
aclocal.m4:872: AC_LIBTOOL_SETUP is expanded from...
aclocal.m4:852: _AC_PROG_LIBTOOL is expanded from...
aclocal.m4:817: AC_PROG_LIBTOOL is expanded from...
configure.ac:17: the top level
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works, ...): suspicious cache-id, must contain _cv_ to be cached
aclocal.m4:1346: AC_LIBTOOL_COMPILER_OPTION is expanded from...
aclocal.m4:5280: AC_LIBTOOL_PROG_COMPILER_PIC is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_CXX, ...): suspicious cache-id, must contain _cv_ to be cached
aclocal.m4:3380: _LT_AC_LANG_CXX_CONFIG is expanded from...
aclocal.m4:3379: AC_LIBTOOL_LANG_CXX_CONFIG is expanded from...
aclocal.m4:2378: _LT_AC_TAGCONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_F77, ...): suspicious cache-id, must contain _cv_ to be cached
aclocal.m4:4407: _LT_AC_LANG_F77_CONFIG is expanded from...
aclocal.m4:4406: AC_LIBTOOL_LANG_F77_CONFIG is expanded from...
configure.ac:17: warning: AC_CACHE_VAL(lt_prog_compiler_pic_works_GCJ, ...): suspicious cache-id, must contain _cv_ to be cached
aclocal.m4:4506: _LT_AC_LANG_GCJ_CONFIG is expanded from...
aclocal.m4:4505: AC_LIBTOOL_LANG_GCJ_CONFIG is expanded from...
/usr/bin/glibtoolize: line 1: cd: /usr/share/libtool: No such file or directory
glibtoolize: cannot list files in `/usr/share/libtool'
configure.ac:8: `automake requires `AM_CONFIG_HEADER', not `AC_CONFIG_HEADER'
aclocal.m4:866: required file `./ltmain.sh' not found
Error: Target org.macports.configure returned: shell command "cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_sysutils_htop/work/htop-0.8.3 && sh autogen.sh" returned error 1
DEBUG: Backtrace: shell command "cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_sysutils_htop/work/htop-0.8.3 && sh autogen.sh" returned error 1
    while executing
"$pre $targetname"
Warning: the following items did not execute (for htop): org.macports.activate org.macports.configure org.macports.build org.macports.destroot org.macports.install
Error: Status 1 encountered during processing.
To report a bug, see <http://guide.macports.org/#project.tickets>

[snc@…]

Added autoreconf in r65197.

[jmr@…]

But as of r65240, you are overwriting the build deps with just git-core, thus removing autoconf, automake and libtool. Fixed in r65779.