Ticket #24542 (closed defect: fixed)
gsoap: livecheck is broken
| Reported by: | hashar@… | Owned by: | stechert@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.8.2 |
| Keywords: | haspatch | Cc: | |
| Port: | gsoap |
Description
While livechecking gsoap port, I had a regex error rendering livecheck impossible.
The project is hosted on sourceforge using roject name "gsoap2" although the name is actually "gsoap" in the RSS feed.
The Portfile contains :
master_sites.mirror_subdir gsoap2
But livecheck was looking at <sourceforge url>?project=gsoap
I patched portlivecheck.tcl so it uses master_sites.mirror_subdir as a livecheck.name and the Portfile so it uses the gsoap name : {{ livecheck.distname = gsoap }}
Attachments
Change History
Changed 3 years ago by hashar@…
- Attachment port_sourceforge_mirror_subdir.patch added
Changed 3 years ago by hashar@…
- Attachment Portfile-gsoap-fix_distname.diff added
gsoap sf project name is gsoap2 but it is named gsoap. That patch makes sure we find the version.
comment:2 Changed 3 years ago by macsforever2000@…
- Keywords haspatch added
- Owner changed from macports-tickets@… to stechert@…
comment:3 Changed 3 years ago by jmr@…
- Component changed from base to ports
Just use sourceforge:gsoap2 in master_sites.
Changed 3 years ago by hashar@…
- Attachment Portfile-gsoap-fix_distname2.diff added
standalone patch that do not require patching the TCL
comment:4 Changed 3 years ago by hashar@…
I reverted my patch and tried sourceforge:gsoap2 which fixes the issue. The default regex does not match a version though :
DEBUG: Fetching http://sourceforge.net/export/rss2_projfiles.php?project=gsoap2 DEBUG: The regex is "(?i)<title>gsoap2 (.*) released.*</title>"
The patch Portfile-gsoap-fix_distname2.diff above fix the Portfile by providing a correct livecheck.regex. That makes the first two patches obsoletes.
livecheck should honor mirror_subdir