New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #24565 (closed update: fixed)

Opened 3 years ago

Last modified 3 years ago

Upgrade lesspipe to 1.71

Reported by: royliu@… Owned by: ingmarstein@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: lesspipe

Description

The title says it all. See patch archive attached.

Attachments

patch.tgz (2.9 KB) - added by royliu@… 3 years ago.
The patch archive.

Change History

Changed 3 years ago by royliu@…

The patch archive.

comment:1 Changed 3 years ago by macsforever2000@…

  • Cc ingmarstein@… removed
  • Owner changed from macports-tickets@… to ingmarstein@…
  • Version 1.8.2 deleted

comment:2 Changed 3 years ago by royliu@…

I might add that the new version finds the correct version of 'tar' for archive viewing, so this request is slightly more than an upgrade.

comment:3 Changed 3 years ago by IngmarStein@…

Well then, could someone apply the patch please?

comment:4 Changed 3 years ago by jmr@…

  • Status changed from new to closed
  • Resolution set to fixed

Sure, done in r67534. Luckily I was trawling through the list of update tickets; normally nobody but the reporter, the owner and those in cc will see ticket comments. If you, as a port's maintainer, would like something committed, the most effective place to ask is on the macports-dev list or on IRC.

Note to the reporter; attaching the patch in an archive like this makes it harder to review. Including whitespace changes for a bunch of lines where nothing functional has changed makes it even harder. The patch also incorrectly removes the Id line.

comment:5 follow-up: ↓ 6 Changed 3 years ago by royliu@…

Sorry about that, my workflow is heavily automated to the point where I just submit whatever my scripts have post-processed. For future reference, should I leave the Id field unchanged? I was always confused about how SVN versions and diffs files with keyword replacements like $Id$.

comment:6 in reply to: ↑ 5 Changed 3 years ago by jmr@…

Replying to royliu@…:

Sorry about that, my workflow is heavily automated to the point where I just submit whatever my scripts have post-processed. For future reference, should I leave the Id field unchanged? I was always confused about how SVN versions and diffs files with keyword replacements like $Id$.

Yes, just leave the Id line unchanged. It is stored in the repository as "# $Id$" and is expanded by the client on checkout. If you can't avoid making whitespace changes in the first place, try using diff -b.

Note: See TracTickets for help on using tickets.