Mailman Upgrade from 2.1.12 to 2.1.13

[mfisher@…]

This patch upgrades Mailman from 2.1.12 to 2.1.13. It also includes variants for the following:

• system_mail: Allow use of system postfix (requires configure option change).
• python26: Include a variant for python26 instead of default python25.

--- Portfile    2010-05-04 16:00:20.000000000 -0400
+++ mailman-portfile    2010-05-04 15:59:59.000000000 -0400
@@ -1,9 +1,10 @@
+# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
 # $Id: Portfile 51955 2009-06-07 10:04:10Z arthurk@macports.org $
 
 PortSystem             1.0
 
 name                   mailman
-version                        2.1.12
+version                        2.1.13
 categories             mail
 maintainers            nomaintainer
 description            Mailman, the GNU Mailing List Manager
@@ -18,9 +19,9 @@
 homepage               http://www.list.org/
 master_sites           sourceforge
 extract.suffix         .tgz
-checksums           md5     d565a6d2d0ec6d2dd6936a81e1c1ca86 \
-                    sha1    6d6281f7ce322e271f0259321f4d8931ff46e6ae \
-                    rmd160  94d8d132bb37180bf4c02ccd2a5fb3862ce13b94
+checksums           md5     3235323ccb3e0135c10b7c66a440390b \
+                    sha1    923dd78a17cbab576354b53a80443fe05f134398 \
+                    rmd160  3a62b04ea0f48c3ecbe815eb927d282f765e416c
 
 platforms              darwin
 
@@ -60,6 +61,23 @@
                        --without-permcheck \
                        --with-python=${prefix}/bin/python2.5
 
+# Variants
+variant system_mail description {Use system postfix} {
+       configure.args-delete \
+               --with-mail-gid=${mmgroup}
+       configure.args-append \
+               --with-mail-gid=nobody
+}
+
+variant python26 {
+       depends_lib-delete      port:python25
+       depends_lib-append      port:python26
+       configure.args-delete \
+               --with-python=${prefix}/bin/python2.5
+       configure.args-append \
+               --with-python=${prefix}/bin/python2.6
+}
+
 pre-destroot {
        addgroup        ${mmgroup}
        adduser         ${mmuser} gid=[existsgroup ${mmgroup}]

[ryandesign@…]

About the variants:

• system_mail: Why should we give users the option to use the system's postfix? This seems to go against our policy of not using system libraries (see the FAQ). Or does the system postfix have features the MacPorts postfix doesn't have? Then again this variant is just changing one configure argument (isn't changing any dependencies). I guess I don't understand how this configure argument works. If the variant is to be kept, we still have the issue that if you select the system_mail variant, you're no longer using the mmgroup variable, but you're still creating the mmgroup and mmuser.
• python26: Is there any reason why the port should not simply switch to using python26 always?

[mfisher@…]

Thanks for the help!

• system_mail: You made some great points. I would be happy to resubmit the patch with this removed entirely (and consider it an interest specific to my site config). If you're interested, here's some Mailman documentation: ​Understanding Group Mismatch Errors--How Mailman Implements Security
• python26: I suggested this just in case there was some reason that sites were sticking with 2.5 still. Since 2.6.5 is considered the current production release, maybe there's not a good reason that 2.5 should be the default.

[mfisher@…]

Updated patch:

• Mailman version bump: 2.1.12 => 2.1.13
• Python dependency version bump: 2.5 => 2.6

Thanks for the feedback!

--- Portfile.orig	2010-05-15 16:04:45.000000000 -0400
+++ Portfile	2010-05-15 16:08:56.000000000 -0400
@@ -1,9 +1,10 @@
 # $Id: Portfile 51955 2009-06-07 10:04:10Z arthurk@macports.org $
+# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
 
 PortSystem		1.0
 
 name			mailman
-version			2.1.12
+version			2.1.13
 categories		mail
 maintainers		nomaintainer
 description		Mailman, the GNU Mailing List Manager
@@ -18,13 +19,13 @@
 homepage		http://www.list.org/
 master_sites		sourceforge
 extract.suffix		.tgz
-checksums           md5     d565a6d2d0ec6d2dd6936a81e1c1ca86 \
-                    sha1    6d6281f7ce322e271f0259321f4d8931ff46e6ae \
-                    rmd160  94d8d132bb37180bf4c02ccd2a5fb3862ce13b94
+checksums   		md5     3235323ccb3e0135c10b7c66a440390b \
+            		sha1    923dd78a17cbab576354b53a80443fe05f134398 \
+            		rmd160  3a62b04ea0f48c3ecbe815eb927d282f765e416c
 
 platforms		darwin
 
-depends_lib		port:python25
+depends_lib		port:python26
 
 # Create a startupitem
 startupitem.create	yes
@@ -58,7 +59,7 @@
 			--with-cgi-gid=${cgigroup} \
 			--with-cgi-ext=.cgi \
 			--without-permcheck \
-			--with-python=${prefix}/bin/python2.5
+			--with-python=${prefix}/bin/python2.6
 
 pre-destroot {
 	addgroup	${mmgroup}

[macsforever2000@…]

Is there a reason you are not attaching the patchfile? That is the preferred method.

[mfisher@…]

Sorry! Didn't catch that. I'll attach the patch directly.

[ryandesign@…]

Thanks, updated in r69576.