mcpp: universal variant fails on Snow Leopard

[ryandesign@…]

mcpp's universal variant fails on Snow Leopard:

DEBUG: Executing org.macports.build (mcpp)
DEBUG: Environment: MACOSX_DEPLOYMENT_TARGET='10.6'
DEBUG: Assembled command: 'cd "/opt/local/var/macports/build/_Users_rschmidt_macports_dports_devel_mcpp/work/mcpp-2.7.2" && /usr/bin/nice -n 10 /usr/bin/make -j1 all CFLAGS+='-isysroot /Developer/SDKs/MacOSX10.4u.sdk -mmacosx-version-min=10.4 -arch i386 -arch ppc''
Making all in src
/usr/bin/make  all-am
/bin/sh ../libtool --tag=CC   --mode=compile /usr/bin/gcc-4.2 -DHAVE_CONFIG_H -I.   -I/opt/local/include  -isysroot /Developer/SDKs/MacOSX10.4u.sdk -mmacosx-version-min=10.4 -arch i386 -arch ppc -c -o support.lo support.c
 /usr/bin/gcc-4.2 -DHAVE_CONFIG_H -I. -I/opt/local/include -isysroot /Developer/SDKs/MacOSX10.4u.sdk -mmacosx-version-min=10.4 -arch i386 -arch ppc -c support.c  -fno-common -DPIC -o .libs/support.o
In file included from support.c:306:
/Developer/SDKs/MacOSX10.4u.sdk/usr/include/stdarg.h:4:25: error: stdarg.h: No such file or directory

Looking in the portfile, it's hardcoded to use the 10.4u SDK and the i386 and ppc architectures! This is not going to work on Snow Leopard. MacPorts provides a slew of variables pre-defined with all the values you need to build universal on the currently-running version of Mac OS X. Please use these instead of hardcoding.

[blair@…]

What changes do you suggest to make to the Portfile?

[jmr@…]

Try this.

[blair@…]

Thanks for the patch. Do I need to bump the revision number for this?

[ryandesign@…]

Ah well, it only affects non-default installs (universal and non-default build_arch), so I might not ordinarily bump the revision, but it only takes under a minute to build, so it's probably not a big inconvenience to bump the revision anyway.

[blair@…]

Thanks! Fixed in r67857. I updated the rev also.