New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #24944 (assigned enhancement)

Opened 3 years ago

Last modified 9 months ago

ImageMagick 6.6.1-5_0 Need no-openmp variant

Reported by: kingjc@… Owned by: ryandesign@…
Priority: Normal Milestone:
Component: ports Version: 1.8.2
Keywords: openmp, haspatch Cc: stephen.langer@…, felix.buenemann@…, rapkasta@…, dburry@…, dojo@…, mmcmahand@…, jeff@…
Port: ImageMagick

Description

Some software has conflicts with OpenMP when used with ImageMagick. In my case, the --disable-openmp option is needed when building ImageMagick to work with the OOF2 Finite Element Code (http://www.ctcms.nist.gov/oof/oof2/). Therefore, I suggesting the attached variant be added to ImageMagick.

Attachments

Portfile-ImageMagick.diff (434 bytes) - added by kingjc@… 3 years ago.
Diff file with proposed variant

Change History

Changed 3 years ago by kingjc@…

Diff file with proposed variant

comment:1 Changed 3 years ago by macsforever2000@…

  • Owner changed from macports-tickets@… to ryandesign@…

comment:2 Changed 3 years ago by dojo@…

Another use case that's going to become more common which triggers the problem is Ruby 1.9 / Rails / RMagick, I assume because of different threading model in Ruby 1.9.

See, for example: http://stackoverflow.com/questions/2838307/why-is-this-rmagick-call-generating-a-segmentation-fault and http://article.gmane.org/gmane.comp.lib.qt.general/26147

comment:3 Changed 3 years ago by jeff@…

This would also be huge for me and my workplace. We're having to patch this ourselves, currently.

comment:4 Changed 3 years ago by mmcmahand@…

+1

comment:5 Changed 3 years ago by ryandesign@…

  • Status changed from new to assigned

A solution that consolidates #15945 and #24944, preferably behind a single +openmp variant, which is a default_variant on 10.6 and not on earlier systems, is needed.

comment:6 Changed 2 years ago by felix.buenemann@…

+1 openmp in ImageMagick 6.7.0 still causes ruby-1.9.2-p180 / rails 3.0.8 / rmagick 2.13.1 to segfault

comment:7 Changed 2 years ago by felix.buenemann@…

  • Cc felix.buenemann@… added

Cc Me!

comment:8 Changed 20 months ago by dburry@…

I've been maintaining my own private fork of this Portfile for 9 months due to this issue (6.6.5-6.7.2)... Being able to negate a default variant would work for me.

comment:9 follow-up: ↓ 10 Changed 9 months ago by dojo@…

After 2 years, it's still necessary to hand edit the Portfile in order to use ImageMagick with Rails / Ruby 1.9 and MacPorts without segmentation faults. That's a common scenario since popular file uploading gems rely on ImageMagick for thumbnail creation.

Can we please add the 3 lines to the ImageMagick portfile as in the supplied patch, to avoid all this hand editing?

comment:10 in reply to: ↑ 9 Changed 9 months ago by ryandesign@…

  • Cc rapkasta@…, dburry@…, dojo@…, mmcmahand@…, jeff@… added

Has duplicate #35123.

Can we please add the 3 lines to the ImageMagick portfile as in the supplied patch, to avoid all this hand editing?

It's not quite as simple as that, considering comment:5 and #34231 and #34950.

I suppose I could make it as simple as just unconditionally turning off OpenMP support altogether, and dealing with the request of providing a variant to turn it back on (in supported configurations) later.

comment:11 Changed 9 months ago by dojo@…

I'm not following why it is not as simple as that, at least for a subset of users, since there are apparently many people that hand edit the file to manually add the variant.

Note: See TracTickets for help on using tickets.