libmcs: fix library install_name and versions

[ryandesign@…]

This patch fixes libmcs.dylib's install_name, compatibility version and current version. Before this patch:

$ otool -L /opt/local/lib/libmcs.dylib
/opt/local/lib/libmcs.dylib:
	libmcs.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 125.0.1)
	/opt/local/lib/libmowgli.dylib (compatibility version 0.0.0, current version 0.0.0)

After this patch:

$ otool -L /opt/local/lib/libmcs.dylib
/opt/local/lib/libmcs.dylib:
	/opt/local/lib/libmcs.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 125.0.1)
	/opt/local/lib/libmowgli.dylib (compatibility version 0.0.0, current version 0.0.0)

This patch includes a few changes from upstream:

• ​Include the library version in the resulting .dylib.
• ​No need for -flat_namespace and -undefined dynamic_lookup is better.

It also undoes part of this upstream change:

• ​Don't use -install_name anymore, it's better to use rpath instead.

I don't understand that change. I don't know what -rpath is all about. And we don't have any ports that depend on libmcs to see if they work properly without my patch. But it seems to me that without -install_name, the library's install_name is not correct. So I brought that part back.

[jdunn@…]

audacious media player ​http://audacious-media-player.org/ depends on libmcs, but i failed to get it working correctly as only version 2.2 would compile but not run, so i gave up on that Portfile. Otherwise im not sure.

[ryandesign@…]

proposed patch

[ryandesign@…]

I meant to add these notes:

Replying to ryandesign@…:

This patch fixes libmcs.dylib's install_name

This patch assumes the patch from #25256 has already been applied.

• ​Include the library version in the resulting .dylib.

This seems like a good idea to add.

• ​No need for -flat_namespace and -undefined dynamic_lookup is better.

I don't totally understand these changes but I suppose they may as well be added.

[ryandesign@…]

Replying to jdunn@…:

audacious media player ​http://audacious-media-player.org/ depends on libmcs, but i failed to get it working correctly as only version 2.2 would compile but not run, so i gave up on that Portfile.

Could you submit your attempted portfile in a new ticket? Maybe I can have a look and make it work.

[jdunn@…]

the patch seems to work great.

[ryandesign@…]

Ok, it's committed in r68832.