id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc	port
25257	libmcs: fix library install_name and versions	ryandesign@…	jdunn@nodetwo.com	"This patch fixes libmcs.dylib's install_name, compatibility version and current version. Before this patch:

{{{
$ otool -L /opt/local/lib/libmcs.dylib
/opt/local/lib/libmcs.dylib:
	libmcs.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 125.0.1)
	/opt/local/lib/libmowgli.dylib (compatibility version 0.0.0, current version 0.0.0)
}}}

After this patch:

{{{
$ otool -L /opt/local/lib/libmcs.dylib
/opt/local/lib/libmcs.dylib:
	/opt/local/lib/libmcs.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 125.0.1)
	/opt/local/lib/libmowgli.dylib (compatibility version 0.0.0, current version 0.0.0)
}}}

This patch includes a few changes from upstream:

 * [https://webkeks.org/hg/buildsys/rev/8bd55aa046bd Include the library version in the resulting .dylib.]
 * [https://webkeks.org/hg/buildsys/rev/d8962c219f95 No need for -flat_namespace and -undefined dynamic_lookup is better.]

It also undoes part of this upstream change:

 * [https://webkeks.org/hg/buildsys/rev/f3c803824649 Don't use -install_name anymore, it's better to use rpath instead.]

I don't understand that change. I don't know what -rpath is all about. And we don't have any ports that depend on libmcs to see if they work properly without my patch. But it seems to me that without -install_name, the library's install_name is not correct. So I brought that part back.
"	defect	closed	Normal		ports	1.9.0	fixed			libmcs