lang/python24: incorrect include path in PortGroup

[danchr (Dan Villiom Podlaski Christiansen)]

The port group for Python 2.4 specifies an incorrect value for ${python.include}, as 2.4 isn't built as a framework. The following trivial patch fixes it:

--- python24-1.0.tcl
+++ python24-1.0.tcl
@@ -37,7 +37,7 @@
 set python.lib	${prefix}/lib/libpython${python.branch}.dylib
 set python.libdir ${frameworks_dir}/Python.framework/Versions/${python.branch}/lib/python${python.branch}
 set python.pkgd	${prefix}/lib/python${python.branch}/site-packages
-set python.include	${frameworks_dir}/Python.framework/Versions/${python.branch}/include/python${python.branch}
+set python.include	${prefix}/include/python${python.branch}
 
 categories		python
 

[jaroel (Roel Bruggink)]

I'll test it and have someone commit the patch. Thanks!

[jmroot (Joshua Root)]

It is built as a framework sometimes, so this needs to be conditional.

[danchr (Dan Villiom Podlaski Christiansen)]

Ah, I see. I just looked at the python24 Portfile and it seems it's this snippet that does it:

…
        # 64-bit, can't build mac-specific stuff
        configure.args-delete --enable-framework=${frameworks_dir}
        configure.args-append --disable-toolbox-glue
        destroot.target       install maninstall
…

What was the reason to not install a framework for 64-bit non-universal builds? It strikes me as a somewhat odd thing to do…

[danchr (Dan Villiom Podlaski Christiansen)]

Bump?

[jaroel (Roel Bruggink)]

Sorry, missed the reply somehow :/

It was committed in r69441, but without any reason. jmr@…, would you mind to explain, 'cause I don't understand.

[jmroot (Joshua Root)]

It was actually added in r56584, for the simple reason that it didn't build otherwise. If you can make the framework and toolbox glue build correctly for 64-bit archs, feel free to do so.

[danchr (Dan Villiom Podlaski Christiansen)]

The attachment above solves this in another way: it disables Python 2.4 for 64-bit architectures. The simplest way to work around the fact that it doesn't build as 64-bit, seems to be not to try building it as such…

[jmroot (Joshua Root)]

Or we could just set the portgroup variables correctly and keep building for the arch that the user has configured.

[jmroot (Joshua Root)]

r71942