kerberos5 build failure with openssl 1.0.0a: too few arguments to function 'EVP_PKEY_decrypt'

[andre.beat@…]

kerberos5 fails to build due to a dumb compiling error. This error is caused by a function call missing an argument. It was pretty simple to fix and I have attached a patch.

This is the compile error

pkinit_crypto_openssl.c:3662: error: too few arguments to function 'EVP_PKEY_decrypt'

[andre.beat@…]

patch

[jmr@…]

Does this also mean there should be a dependency on openssl?

[andre.beat@…]

From pkinit_crypto_openssl.h

#include <openssl/bn.h>
#include <openssl/dh.h>
#include <openssl/x509.h>
#include <openssl/pkcs7.h>
#include <openssl/pkcs12.h>
#include <openssl/obj_mac.h>
#include <openssl/x509v3.h>
#include <openssl/err.h>
#include <openssl/evp.h>
#include <openssl/asn1_mac.h>
#include <openssl/sha.h>
#include <openssl/asn1.h>
#include <openssl/pem.h>

So yes, I think openssl should be a dependency. I already had it installed that's why I haven't noticed it.

[ryandesign@…]

Remember to use WikiFormatting, please.

[andre.beat@…]

I'm really sorry I haven't done that in the first place. Thanks for the heads-up ;)

[ryandesign@…]

Port fixed in r70028; thanks for the patch.

[michaelld@…]

I think I've got a better set of solutions, which if neither of you object to then I'll check in shortly:

1. Upgrade to 1.8.2 -- this solves some issues right off the bat;

2. Use '--disable-pkinit' to get rid of OpenSSL dependency;

3. Tweak install of includes to be in ${prefix}/include/kerberos5/ or /krb5/ . There are a number of "top-level" headers in this port; I think moving them to a subdir makes sense. And, very little depends on Kerberos5 so this isn't a big issue (I think).

Please let me know your thoughts. If you want a Portfile diff to try out, I'll do my best to attach one (I'm in the middle of nowhere in Central America, with so-so internet).