Opened 14 years ago

Closed 14 years ago

#26040 closed submission (wontfix)

New port: xymon

Reported by: fclaire@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.9.1
Keywords: Cc:
Port: xymon

Description

Here's a port of the famous xymon network monitoring system.

It installs the client by default. To install the server use "+server -client" variants.

Thanks for checking it.

Attachments (6)

Portfile (12.0 KB) - added by fclaire@… 14 years ago.
INSTALL.macports.xymon.server (3.0 KB) - added by fclaire@… 14 years ago.
org.macports.xymon.server.plist (753 bytes) - added by fclaire@… 14 years ago.
patch-build-Makefile.rules.diff (313 bytes) - added by fclaire@… 14 years ago.
patch-client-hobbitclient-darwin.sh.diff (580 bytes) - added by fclaire@… 14 years ago.
patch-lib-Makefile.diff (299 bytes) - added by fclaire@… 14 years ago.

Download all attachments as: .zip

Change History (9)

Changed 14 years ago by fclaire@…

Attachment: Portfile added

Changed 14 years ago by fclaire@…

Changed 14 years ago by fclaire@…

Changed 14 years ago by fclaire@…

Changed 14 years ago by fclaire@…

Changed 14 years ago by fclaire@…

Attachment: patch-lib-Makefile.diff added

comment:1 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Port: xymon added

I have not spent a lot of time evaluating this, but my initial impressions are

  • this looks exceptionally complicated
  • the server and client variants would seem to be totally conflicting with one another, and should therefore so indicate, however wouldn't it make a lot more sense to have two separate ports, one for the client and one for the server? call the client port "xymon" and call the server "xymon-server"; this matches how we handle postgresql and mysql now
  • master_sites can just be "sourceforge"
  • the first revision of any port version should usually be 0, not 1; you can just omit the revision line entirely to accomplish that
  • why use a beta version, and not a stable version?
  • you must not "file mkdir" in the main part of a port; that would get executed even on such operations as "port info"; you probably want the destroot.keepdirs command in this case
  • it's usually simplest to use "ln -s" instead of "file link -symbolic" or "system 'ln -s'" to create symlinks; there are some cases where this won't work; if this is one of those cases, please add a comment in the portfile explaining it so others don't wonder
  • we prefer to use notes now, instead of manually calling ui_msg in post-activate
  • you shouldn't hardcode /opt/local, not even in messages printed to the user; use ${prefix}

comment:2 Changed 14 years ago by fclaire@…

Thanks for checking this port.

  • yes, it's complicated. It took me some time to make it working and - believe me - I don't do complicated stuff for the sake of it. Any proposal to make it simpler is welcomed.
  • I thought about it and decided to make a single Portfile as both the client and server are in the same source tarball and the server acts as a client to itself too. But you're right I'll make 2 separate ports, it'll be easier to install and simpler. I'll make 2 new submission tickets for them in the coming days.
  • the new Portfiles will have sourceforge only
  • will be removed in the new Portfiles
  • the latest stable version (4.2.3) is dated 02/2009. This second beta version (4.3.0) is a bit more recent (04/2009) and seems quite stable. I don't know why there hasn't been a stable 4.3.0 released yet. I don't want to build a package on too old stuff so I choosed this one.
  • ok, I'll remove the "file mkdir"
  • ok, will try 'ln -s'
  • I tried to get some doc about how to display the content of a file to the user but found nothing. I'll have a look at notes -> any link/hint is welcomed
  • ok, ${prefix}.

comment:3 Changed 14 years ago by raimue (Rainer Müller)

Resolution: wontfix
Status: newclosed

Superseded by #26174 and #26175.

Note: See TracTickets for help on using tickets.