spidermonkey 1.7.0 +fileobject does not actually enable the file object

[onne@…]

somehow due to the config/Darwin.mk the JS_HAS_FILEOBJECT=1 fails to be passed on during compile as -DJS_HAS_FILEOBJECT

manually configuring, changing config/Darwin.mk and then installing it works out

a quick way to see if it has build correctly:

strings which js | grep js_NewFileObjectFromFILE

echo "no fileobject"

[vjt@…]

Hello,

the following patch both fixes the reported problem, and enables readline support in the interactive JS shell.

The reason is that the DEFINES= parameter to make is shadowing the Makefile.ref generated $(DEFINES) variable. Anyway, if the -DJS_C_STRINGS_ARE_UTF8 is not specified on the command line, it gets added automagically by Makefile.ref, at least on my machine (Macports 1.9.1, Darwin 10.4.0/x86_64).

--- Portfile~	2010-11-04 12:26:07.000000000 +0100
+++ Portfile	2010-11-04 12:26:33.000000000 +0100
@@ -51,7 +51,7 @@
                     LIBDIR="/lib" \
                     SO_SUFFIX=dylib \
                     JS_THREADSAFE=1 \
-                    DEFINES=-DJS_C_STRINGS_ARE_UTF8
+                    JS_READLINE=1
 
 if { ![variant_isset universal] } {
     build.args-append CC='${configure.cc} -arch ${build_arch}'

[vjt@…]

Cc Me!

[kwatch@…]

How about progress? I confirmed that the above patch works well (thanks vjt!).

I hope Macports to include the patch.

[pixilla (Bradley Giesbrecht)]

Fixed in r76712.