ncftp fails to build: conflicting types for getdomainname

[macports@…]

This is on MacOS 10.6.4 on a MacBook Pro.

The relevant portion of the log is:

:info:build Compiling PWrite.c.
:info:build   /usr/bin/gcc-4.2 -D_REENTRANT -pipe -O2 -arch x86_64 -Wno-format-y2k -static-libgcc
:info:build    -DMACOSX -DHAVE_CONFIG_H -DMACOSX -I/opt/local/var/macports/build/_opt_mports_trun
:info:build   k_dports_net_ncftp/work/ncftp-3.2.4 -I/opt/local/var/macports/build/_opt_mports_tru
:info:build   nk_dports_net_ncftp/work/ncftp-3.2.4/libncftp -I/opt/local/var/macports/build/_opt_
:info:build   mports_trunk_dports_net_ncftp/work/ncftp-3.2.4/sio -I/opt/local/var/macports/build/
:info:build   _opt_mports_trunk_dports_net_ncftp/work/ncftp-3.2.4/Strn -I/opt/local/include DNSUt
:info:build   il.c -c:info:build   DNSUtil.c:22: error: conflicting types for 'getdomainname'
:info:build   /usr/include/unistd.h:531: error: previous declaration of 'getdomainname' was here
:info:build 
:info:build make[1]: *** [DNSUtil.o] Error 1

Complete build log attached.

[macports@…]

Build log for NCFTP

[jmroot (Joshua Root)]

Please remember to cc the maintainer.

[michaelld (Michael Dickens)]

I'm attaching a patch that fixes it for me on x86_64, and should work on any Darwin platform (no matter 32 or 64 bit). The issue is that the function 'getdomainname' -always- takes an 'int' for its second argument (at least on Darwin), but the release code uses 'gethostname_size_t' which will end up being a 'size_t' type -- which is -not- an 'int' no matter how many bits you have. This patch replaces the 'gethostname_size_t' with 'int' in just the single file of issue: sio/DNSUtil.c .

[michaelld (Michael Dickens)]

Patch to correct 'gethostname_size_t' usage in 'getdomainname' function.

[michaelld (Michael Dickens)]

Cc Me!

[tobypeterson]

Better fix committed in r74679