watch 3.2.8 doesn't honor build_arch

[jon.hermansen@…]

Running Snow Leopard, I modified my build_arch to be i386 and encountered this issue:

ld: warning: in /opt/local/lib/libncurses.dylib, file was built for i386 which is not the architecture being linked (x86_64)
Undefined symbols:
  "_noecho", referenced from:
      _main in watch.o
  "_endwin", referenced from:
      _do_exit in watch.o
  "_wmove", referenced from:
      _main in watch.o
      _main in watch.o
      _main in watch.o
      _main in watch.o
  "_initscr", referenced from:
      _main in watch.o
  "_wrefresh", referenced from:
      _main in watch.o
  "_cbreak", referenced from:
      _main in watch.o
  "_resizeterm", referenced from:
      _main in watch.o
  "_stdscr", referenced from:
      _main in watch.o
      _main in watch.o
      _main in watch.o
      _main in watch.o
      _main in watch.o
      _main in watch.o
      _main in watch.o
      _main in watch.o
      _main in watch.o
      _main in watch.o
      _main in watch.o
      _main in watch.o
      _main in watch.o
  "_wclear", referenced from:
      _main in watch.o
  "_waddnstr", referenced from:
      _main in watch.o
      _main in watch.o
      _main in watch.o
  "_nonl", referenced from:
      _main in watch.o
  "_waddch", referenced from:
      _main in watch.o
      _main in watch.o
  "_winch", referenced from:
      _main in watch.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
make: *** [watch] Error 1
shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_sysutils_watch/work/procps-3.2.8" && /usr/bin/make -j4 watch CC=/usr/bin/gcc-4.2 LDFLAGS="-L/opt/local/lib" PKG_LDFLAGS="" CPPFLAGS="-I/opt/local/include -I/opt/local/include/ncurses" " returned error 2
Error: Target org.macports.build returned: shell command failed
DEBUG: Backtrace: shell command failed
    while executing
"command_exec build"
    (procedure "portbuild::build_main" line 8)
    invoked from within
"$procedure $targetname"
Warning: the following items did not execute (for watch): org.macports.activate org.macports.build org.macports.destroot org.macports.archive org.macports.install
Log for watch is at: /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_sysutils_watch/main.log
Error: Status 1 encountered during processing.

I've attached a patch which fixes this by adding ${configure.cc_archflags} to CC.

[ryandesign (Ryan Carsten Schmidt)]

Let's handle the universal variant, too.

[ryandesign (Ryan Carsten Schmidt)]

proposed patch

[mjhsieh@…]

I haven't got a chance to work with $build_arch=i386 yet, but I do want to confirm that Ryan's patch works fine with +universal in my SL machine. The patch looks fine, too.

[ryandesign (Ryan Carsten Schmidt)]

Committed in r71752.