Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#27330 closed defect (fixed)

smartmontools @5.40_0: update-smart-drivedb script requires GNU sed

Reported by: takanori@… Owned by: tobypeterson
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: gsed Cc:
Port: smartmontools

Description

update-smart-drivedb script doesn't work properly with BSD sed since it contains ERE.

Here is a patch to fix this problem.

Attachments (2)

smartmontools.diff​ (2.1 KB) - added by takanori@… 13 years ago.
smartmontools.diff
update-smart-drivedb-sed.patch​ (756 bytes) - added by Christian.Franke@… 13 years ago.
This should work with any sed

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by takanori@…

Attachment: smartmontools.diff​ added

smartmontools.diff

comment:1 Changed 13 years ago by jmroot (Joshua Root)

Couldn't you just use sed -E?

comment:2 Changed 13 years ago by takanori@…

I know TIMTOWTDI. ;-)

In this case, using GNU sed is more reliable than using BSD sed with -E option, I think.

Changed 13 years ago by Christian.Franke@…

Attachment: update-smart-drivedb-sed.patch​ added

This should work with any sed

comment:3 Changed 13 years ago by Christian.Franke@…

Please test update-smart-drivedb-sed.patch with BSD sed if possible.

Then I could fix this upstream (​Smartmontools Ticket #126).

comment:4 Changed 13 years ago by takanori@…

Resolution: → fixed
Status: new → closed

Your patch worked perfectly. (tested on Mac OS X 10.6.5/x86_64 and 10.5.8/ppc)

Committed in r73687 - Thanks!

comment:5 Changed 13 years ago by Christian.Franke@…

Thanks for testing. Committed upstream in ​r3214.

Note: See TracTickets for help on using tickets.