New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #27351 (closed update: fixed)

Opened 3 years ago

Last modified 2 years ago

UPDATE: bcfg2 1.1.1

Reported by: sol.jerome@… Owned by: ryandesign@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc:
Port: bcfg2

Description

Bcfg2 1.1.1 is available.

Attachments

Portfile.diff (901 bytes) - added by sol.jerome@… 2 years ago.
Updated Portfile
patch-setup.py.diff (3.0 KB) - added by sol.jerome@… 2 years ago.
Updated setup.py patch

Change History

comment:1 Changed 3 years ago by jmr@…

  • Version 1.9.2 deleted
  • Type changed from defect to update

comment:2 follow-up: ↓ 5 Changed 2 years ago by ryandesign@…

  • Owner changed from macports-tickets@… to ryandesign@…
  • Status changed from new to assigned

Thank you for the update, however the patch did not apply cleanly to the current portfile in our repository. (The license line in our portfile was in a different place than your patch suggested.) In the future please supply diffs against the current portfile in our repository.

comment:3 Changed 2 years ago by ryandesign@…

Also, patch says your patch-setup.py.diff is malformed.

patching file setup.py
/usr/bin/patch: **** malformed patch at line 48:  

Could you supply a new patch-setup.py.diff that patch can use?

comment:4 Changed 2 years ago by ryandesign@…

Updated your maintainer email address in r73575.

Changed 2 years ago by sol.jerome@…

Updated Portfile

comment:5 in reply to: ↑ 2 Changed 2 years ago by sol.jerome@…

Replying to ryandesign@…:

Thank you for the update, however the patch did not apply cleanly to the current portfile in our repository. (The license line in our portfile was in a different place than your patch suggested.) In the future please supply diffs against the current portfile in our repository.

Sorry about that. It must have been updated somewhere in between (or I didn't grab it from here to begin with). Updated patch against current trunk.

Replying to ryandesign@…:

Also, patch says your patch-setup.py.diff is malformed.

patching file setup.py
/usr/bin/patch: **** malformed patch at line 48:

Could you supply a new patch-setup.py.diff that patch can use?

My fault again. That previous patch appears to be truncated. I have reattached with the proper diff. Thanks for your help!

comment:6 follow-up: ↓ 7 Changed 2 years ago by ryandesign@…

Thanks. The new setup.py patch still doesn't apply though. According to the patch, it's for version 1.1.0, but you're requesting the port be updated to version 1.1.1.

Changed 2 years ago by sol.jerome@…

Updated setup.py patch

comment:7 in reply to: ↑ 6 Changed 2 years ago by sol.jerome@…

Replying to ryandesign@…:

Thanks. The new setup.py patch still doesn't apply though. According to the patch, it's for version 1.1.0, but you're requesting the port be updated to version 1.1.1.

Ugh, this is where it'd help to have a Mac to test this on. Updated patch to apply cleanly against a checkout of bcfg2 1.1.1:

$ cd bcfg2-1.1.1/
$ patch -p0 < patch-setup.py.diff 
patching file setup.py

Sorry about all the hassle.

comment:8 Changed 2 years ago by ryandesign@…

  • Status changed from assigned to closed
  • Resolution set to fixed

Thanks, updated in r73577. I also added "supported_archs noarch" because this port does not appear to install any architecture-specific files.

Note: See TracTickets for help on using tickets.