Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#27454 closed defect (fixed)

svn.post_args can't safely be changed

Reported by: anddam (Andrea D'Amore) Owned by: macports-tickets@…
Priority: Normal Milestone: MacPorts 2.0.0
Component: base Version: 1.9.99
Keywords: Cc: ryandesign (Ryan Carsten Schmidt)
Port:

Description (last modified by ryandesign (Ryan Carsten Schmidt))

When using a svn.post_args-append option in Portfile revision doesn't get appended to svn.args anymore as it should in trunk/base/src/port1.0/portfetch.tcl?rev=73333#L356

Example

svn.revision    123
svn.post_args-append    ${name}-${version}/build

Change History (4)

comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added
Description: modified (diff)
Milestone: MacPorts 2.0.0

Don't futz with the svn.post_args then. :)

The change I'd like to see to base is that svn fetching should fetch into a directory whose name is ${worksrcdir}; the portfile author should be able to change worksrcdir and have it automatically reflected in the fetch. This is how "use_dmg yes" already works, and I think the hg and git fetch types also do this.

comment:2 Changed 13 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed
Summary: svn.fetch doesn't append revisionsvn.post_args can't safely be changed

comment:3 Changed 13 years ago by jmroot (Joshua Root)

Milestone: MacPorts Future

comment:4 Changed 13 years ago by jmroot (Joshua Root)

Milestone: MacPorts FutureMacPorts 2.0.0
Note: See TracTickets for help on using tickets.