New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #27794 (assigned submission)

Opened 2 years ago

Last modified 7 weeks ago

New port: ige-mac-bundler 0.6.0

Reported by: mike@… Owned by: ryandesign@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: suv-sf@…, tael67@…, egall@…
Port: ige-mac-bundler

Description

New port: ige-mac-bundler 0.6.0

Attachments

Portfile (1.3 KB) - added by mike@… 2 years ago.
Portfile.diff (930 bytes) - added by gellule.xg@… 2 years ago.
Portfile.2 (1.6 KB) - added by gellule.xg@… 2 years ago.
Newer Portfile, with some needed patches.
patch-bundler-bundler.py.diff (1009 bytes) - added by gellule.xg@… 2 years ago.
patch-bundler-launcher.sh.diff (331 bytes) - added by gellule.xg@… 2 years ago.
Portfile.3 (2.0 KB) - added by t.tensi@… 7 weeks ago.
Portfile for gtk-mac-bundler 0.7.3
patch-bundler_py.diff (480 bytes) - added by t.tensi@… 7 weeks ago.
patch file for bundler.py (adapted version for 0.7.3)
patch-launcher_sh.diff (331 bytes) - added by t.tensi@… 7 weeks ago.
patch file for launcher.sh (version for 0.7.3, identical to old version)

Change History

Changed 2 years ago by mike@…

comment:1 Changed 2 years ago by jmr@…

  • Version 1.9.2 deleted
  • Type changed from enhancement to submission

comment:2 Changed 2 years ago by ryandesign@…

  • Owner changed from macports-tickets@… to ryandesign@…
  • Status changed from new to assigned
  • Port set to ige-mac-bundler

Thanks.

comment:3 Changed 2 years ago by ryandesign@…

Committed in r74669 with these changes:

  • reformatted whitespace
  • removed commented-out dependencies
  • removed md5 checksum which I consider to be obsolete
  • changed "configure {}" to "use_configure no" (see "port lint")
  • replaced "exec cp -R" with "copy"
  • tweaked livecheck settings

I also meant to indicate that this software does not install any architecture-specific files, but I forgot; I committed that change in r74670.

However, I don't think the software works, because:

  1. The script ${prefix}/bin/ige-mac-bundler begins with:
    #!/usr/bin/env python
    
    That means it will run using whatever python the user happens to have selected, or Mac OS X's python if the user hasn't selected one. Instead, the port should declare a dependency on a specific version of python (2.7, I guess, since that's the python into whose directory you've copied the files) and use that specific version of python in the shebang line.
  1. Next, the script reads:
    sys.path.insert(0, '/i386-10.6-mp/var/macports/build/_Users_rschmidt_macports_dports_devel_ige-mac-bundler/work/ige-mac-bundler-0.6.0')
    
    That path does not exist after the port has been installed; that's the work directory that MacPorts (by default) cleans up after a successful installation. Trying to run the script gives me:
    Traceback (most recent call last):
      File "/i386-10.6-mp/bin/ige-mac-bundler", line 5, in <module>
        import bundler.main
    ImportError: No module named bundler.main
    
    So this path needs to be changed to something else before installation.

Can you attach a patch to address these issues?

Changed 2 years ago by gellule.xg@…

comment:4 Changed 2 years ago by gellule.xg@…

ryandesign, I just attached the patch you were looking for. Hope it works for you. Regards, -Julien/Gellule

Changed 2 years ago by gellule.xg@…

Newer Portfile, with some needed patches.

Changed 2 years ago by gellule.xg@…

Changed 2 years ago by gellule.xg@…

comment:5 Changed 2 years ago by gellule.xg@…

ryandesign,

I attached a new Portfile.2 as well as the patches referenced. Some explanations:

In patch-bundler-bundler.py.diff
+            fout.write("\n")

This is from upstream, not in version 0.6.0 of ige-mac-integration

In patch-bundler-bundler.py.diff
-        self.copy_path(Path("${prefix}/lib/charset.alias"))
+        self.copy_path(Path("/usr/lib/charset.alias", dest="${bundle}/Contents/Resources"))

This is because MacPorts does not have charset.alias in /opt/local/lib. I do hope that it is always found in /usr/lib.

In patch-bundler-bundler.py.diff
-        f.write("ModuleFiles=./pango.modules\n")
+        f.write("ModuleFiles=./Contents/Resources/etc/pango/pango.modules\n")
In patch-bundler-launsher.sh.diff
+cd $bundle

The version of pango produced by MacPorts does not like "./pango.modules". I have no idea why I needed that, but it works. Comments from John Ralls (ige-mac-bundler's maintainer):

That must be something MacPorts is doing differently from Gtk-OSX.
When I copy pango-querymodules into a bundle and edit the launcher
script to run it, I get the expected list of modules printed to Console,
with no changing directories or editing pangorc. 

comment:6 Changed 2 years ago by suv-sf@…

Could the example files as well as the available docs (Changelog, INSTALL, README, …) be installed as well? (Portfile.2 only installs the bundler scripts).

comment:7 Changed 2 years ago by suv-sf@…

  • Cc suv-sf@… added

Cc Me!

comment:8 Changed 2 years ago by gellule.xg@…

Is there a recommended location/layout to install these additional files? Would /opt/local/share/ige-mac-bundler work?

comment:9 Changed 2 years ago by tael67@…

  • Cc tael67@… added

Cc Me!

comment:10 Changed 19 months ago by jmr@…

  • Keywords haspatch added

comment:11 follow-up: ↓ 13 Changed 4 months ago by egall@…

Isn't this already an existing port?

comment:12 Changed 4 months ago by egall@…

  • Cc egall@… added

Cc Me!

comment:13 in reply to: ↑ 11 Changed 4 months ago by larryv@…

Replying to egall@…:

Isn't this already an existing port?

See comment:3.

Changed 7 weeks ago by t.tensi@…

Portfile for gtk-mac-bundler 0.7.3

Changed 7 weeks ago by t.tensi@…

patch file for bundler.py (adapted version for 0.7.3)

Changed 7 weeks ago by t.tensi@…

patch file for launcher.sh (version for 0.7.3, identical to old version)

comment:14 Changed 7 weeks ago by t.tensi@…

Dear all,

John Ralls renamed the "ige-mac-bundler" to "gtk-mac-bundler" some time ago, so I recommend to use that name for the port. Also the 0.6.0 version is outdated, the current version is 0.7.3.

I have enclosed a new portfile and adapted the patch files of Julien.

Best regards, Thomas

Note: See TracTickets for help on using tickets.