New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #27923 (closed defect: fixed)

Opened 2 years ago

Last modified 20 months ago

gtksourceview2 does not build properly against gtk2 +quartz

Reported by: tigerfishdaisy@… Owned by: micah.lerner@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc: bgrupe@…, hsivank@…, a.y.harano@…, danlipsitt@…, rizwank@…, philip.chimento@…, pavel@…, timwhite88@…, snc@…
Port: gtksourceview2

Description (last modified by jmr@…) (diff)

gtksourceview2 will not build properly against gtk2 +quartz

--> does not pull in ige-mac-integration for menus --> does not include headers for IgeMacBundle

info:build gtksourceview-i18n.c: In function 'get_locale_dir':
:info:build gtksourceview-i18n.c:48: error: 'IgeMacBundle' undeclared (first use in this function)
:info:build gtksourceview-i18n.c:48: error: (Each undeclared identifier is reported only once
:info:build gtksourceview-i18n.c:48: error: for each function it appears in.)
:info:build gtksourceview-i18n.c:48: error: 'bundle' undeclared (first use in this function)

Attachments

gtksourceview_gtksourceview-i18n.c.diff (837 bytes) - added by hsivank@… 2 years ago.
Portfile_gtksourceview2.diff (593 bytes) - added by hsivank@… 2 years ago.

Change History

comment:1 Changed 2 years ago by jmr@…

  • Description modified (diff)

There doesn't appear to be a port named gtkintegration2. Which port did you mean to report this against? Also, please remember to preview and use WikiFormatting.

comment:2 Changed 2 years ago by tigerfishdaisy@…

My mistake. gtksourceview2.

comment:3 Changed 2 years ago by jmr@…

  • Port changed from gtkintegration2 to gtksourceview2
  • Owner changed from macports-tickets@… to micah.lerner@…
  • Description modified (diff)
  • Summary changed from gtkintegration2 does not build properly against gtk2 +quartz to gtksourceview2 does not build properly against gtk2 +quartz

comment:4 Changed 2 years ago by bgrupe@…

  • Cc bgrupe@… added

Cc Me!

Changed 2 years ago by hsivank@…

Changed 2 years ago by hsivank@…

comment:5 Changed 2 years ago by hsivank@…

Need to be tested ...

comment:6 Changed 2 years ago by hsivank@…

  • Cc hsivank@… added

Cc Me!

comment:7 Changed 2 years ago by a.y.harano@…

  • Cc a.y.harano@… added

Cc Me!

comment:8 follow-up: ↓ 10 Changed 2 years ago by bskaplan14@…

Digging through some stuff, it seems that ige-mac-bundle uses Carbon, so it won't work in 64-bit. The entire header is wrapped in an #ifndef x86_64. Until gtksourceivew switches to using GtkOSXApplication, we can't get a 64-bit quartz gtksourceview.

comment:9 Changed 2 years ago by danlipsitt@…

  • Cc danlipsitt@… added

Cc Me!

comment:10 in reply to: ↑ 8 Changed 2 years ago by danlipsitt@…

Replying to bskaplan14@…:

Digging through some stuff, it seems that ige-mac-bundle uses Carbon, so it won't work in 64-bit. The entire header is wrapped in an #ifndef x86_64. Until gtksourceivew switches to using GtkOSXApplication, we can't get a 64-bit quartz gtksourceview.

I think hsivank's patches are all that is needed. The only code it's using is for determining the path to the locale files. Can we get this into the official package?

comment:11 Changed 2 years ago by rizwank@…

  • Cc rizwank@… added

Cc Me!

comment:12 Changed 2 years ago by rizwank@…

Is this all thats required to get gtksourceview2 to work with the new gtk-osx-application?

comment:13 Changed 2 years ago by philip.chimento@…

  • Cc philip.chimento@… added

Cc Me!

comment:14 Changed 23 months ago by pavel@…

  • Cc pavel@… added

Cc Me!

comment:15 Changed 22 months ago by timwhite88@…

After applying the attached patches (and correcting the checksums to include the checksum for the patch file), I was able to get gtksourceview2 to compile and install. I needed it for gedit to install. However I've hit another problem with Gedit to do with IgeMacMenuGroup so not sure if the patches are all thats needed. This is under Lion

comment:16 Changed 22 months ago by timwhite88@…

  • Cc timwhite88@… added

Cc Me!

comment:17 Changed 20 months ago by snc@…

  • Cc snc@… added

Cc Me!

comment:18 Changed 20 months ago by snc@…

  • Status changed from new to closed
  • Resolution set to fixed

Patched in r85979. maintainer timeout

Note: See TracTickets for help on using tickets.