Opened 13 years ago

Closed 12 years ago

#28281 closed defect (fixed)

VLC is out of date

Reported by: carsomyr@… Owned by: jeremyhu (Jeremy Huddleston Sequoia)
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc: fuhrmann_mail@…, nonstop.server@…, jeremyhu (Jeremy Huddleston Sequoia)
Port: vlc

Description

The VLC port build failed for me because of the recent upgrade in libmatroska (see attached main.log). I've included a fix bundled as an upgrade to 1.17. Please find the patch archive attached. Some key points:

  • No more dependency on the 10.5 SDK.
  • Many configure options have disappeared.
  • Fixed plugin search problems with a small code patch.

Hoping it works out of the box for others!

Attachments (4)

main.log (927.7 KB) - added by carsomyr@… 13 years ago.
The failed build log.
errors with qt4.log (249.1 KB) - added by fuhrmann_mail@… 13 years ago.
error log for +qt4 variant.
patch.tgz (6.9 KB) - added by carsomyr@… 13 years ago.
The updated Port patch archive.
VLC-1.1.7-WIP.patch (31.5 KB) - added by jeremyhu (Jeremy Huddleston Sequoia) 12 years ago.
VLC-1.1.7-WIP.patch

Download all attachments as: .zip

Change History (23)

Changed 13 years ago by carsomyr@…

Attachment: main.log added

The failed build log.

comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Owner: changed from macports-tickets@… to mnick@…
Port: vlc added
Summary: VLC 1.0.6 build fails (have patch to 1.17)VLC 1.0.6 build fails (have patch to 1.1.7)

Changed 13 years ago by fuhrmann_mail@…

Attachment: errors with qt4.log added

error log for +qt4 variant.

comment:2 Changed 13 years ago by fuhrmann_mail@…

I have tested the patches with the +qt4 variant. Also I have changed use_parallel_build to yes as I have build vlc several times with -j2 and haven't encountered any problems (I don't know why this is set to no).

Nevertheless the build fails, it seems that moc is called with the wrong parameters. I have attached the error log. (This error is not related to "use_parallel_build yes" as I have also tested it with no and there is the same result.)

comment:3 Changed 13 years ago by fuhrmann_mail@…

Addition: The same problem occurs when compiling vlc without any variant.

comment:4 Changed 13 years ago by fuhrmann_mail@…

Cc: fuhrmann_mail@… added

Cc Me!

comment:5 in reply to:  3 Changed 13 years ago by carsomyr@…

Replying to fuhrmann_mail@…:

Addition: The same problem occurs when compiling vlc without any variant.

I rebuilt it, and everything seems OK. Could you attach a log for your failed build of VLC without any variants? Also, Snow Leopard or Leopard?

comment:6 Changed 13 years ago by fuhrmann_mail@…

Sorry, my mistake: I have just discovered that I set +qt4 as a default variant several months ago and forgot about it. Now compile works for me, too. (Snow Leopard)

But now I have another problem, but it is possible that this is the fault of my specific system: All Videos have no audio, the vlc log says:

auhal debug: system has [10] device(s)
auhal debug: DevID: 271 DevName: Mikrofon (integriert)
auhal debug: this device is INPUT only. skipping...
auhal debug: DevID: 269 DevName: Eingang (integriert)
auhal debug: this device is INPUT only. skipping...
auhal debug: DevID: 273 DevName: Ausgang (integriert)
auhal debug: this device is INPUT only. skipping...
auhal debug: DevID: 265 DevName: Soundflower (2ch)
auhal debug: this device is INPUT only. skipping...
auhal debug: DevID: 262 DevName: Soundflower (16ch)
auhal debug: this device is INPUT only. skipping...
...
auhal warning: could not check whether device [0x0] is alive: ved!
auhal warning: selected audio device is not alive, switching to default device

Does sound work for you?

comment:7 in reply to:  6 Changed 13 years ago by carsomyr@…

It seems like forcing the 10.5 SDK (as it was before) enables sound, too. I've overwritten the Port patch archive. Only these lines are added back in:

     --with-macosx-version-min=10.5 \
     --with-macosx-sdk=/Developer/SDKs/MacOSX10.5.sdk \

Sound should work for you now. As for the qt4 problem, it may be a lost cause until the moc port gets updated.

Changed 13 years ago by carsomyr@…

Attachment: patch.tgz added

The updated Port patch archive.

comment:8 Changed 13 years ago by fuhrmann_mail@…

Hmm, there is no dedicated moc port. /opt/local/bin/moc is part of the qt4-mac package, which seems up to date.

With the latest change audio works for me, too. Now I have only seen minor problems: Preferences cannot be opened, localization don't work. (Perhaps it can be fixed but it is not so much important.)

comment:9 Changed 13 years ago by carsomyr@…

Any chance these changes will be added to the trunk?

comment:10 Changed 12 years ago by nonstop.server@…

Cc: nonstop.server@… added

Cc Me!

comment:11 Changed 12 years ago by nonstop.server@…

It would be very nice to have an update on port VLC.
The current port for VLC builds fine, but it is unable to play any sound on Snow Leopard or Lion.

comment:12 Changed 12 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Attaching a tarball full of files and patches is way more complicated than just providing a single patch...

comment:13 Changed 12 years ago by jeremyhu (Jeremy Huddleston Sequoia)

I tried doing this today. Since there was work done in this bug report for 1.1.7, I decided to try with 1.1.7 rather than jumping to 1.1.13 or 2.0.1. Here is my patch against current VLC.

Audio does not work, and the Preferences window does not open with an error loading a nib (I didn't look into it further):

2012-05-01 22:20:20.928 VLC[9048:707] (
	0   CoreFoundation                      0x00007fff88b9ad36 __exceptionPreprocess + 198
	1   libobjc.A.dylib                     0x00007fff84b78444 objc_exception_throw + 43
	2   CoreFoundation                      0x00007fff88c2eaf9 -[NSException raise] + 9
	3   Foundation                          0x00007fff8bd01f8e -[NSObject(NSKeyValueCoding) valueForUndefinedKey:] + 238
	4   Foundation                          0x00007fff8bc3cf5d -[NSObject(NSKeyValueCoding) valueForKey:] + 400
	5   Foundation                          0x00007fff8bc5ae9e -[NSObject(NSKeyValueCoding) valueForKeyPath:] + 341
	6   AppKit                              0x00007fff870e738d -[NSBinder valueForBinding:resolveMarkersToPlaceholders:] + 163
	7   AppKit                              0x00007fff872df4df -[NSValueBinder _adjustObject:mode:observedController:observedKeyPath:context:editableState:adjustState:] + 667
	8   AppKit                              0x00007fff872df134 -[NSValueBinder _observeValueForKeyPath:ofObject:context:] + 192
	9   AppKit                              0x00007fff870d97be -[NSObject(NSKeyValueBindingCreation) bind:toObject:withKeyPath:options:] + 641
	10  AppKit                              0x00007fff870d2cfa -[NSIBObjectData nibInstantiateWithOwner:topLevelObjects:] + 1012
	11  AppKit                              0x00007fff870c9a64 loadNib + 317
	12  AppKit                              0x00007fff870c8f7a +[NSBundle(NSNibLoading) _loadNibFile:nameTable:withZone:ownerBundle:] + 219
	13  AppKit                              0x00007fff870c8dd4 +[NSBundle(NSNibLoading) loadNibNamed:owner:] + 370
	14  libmacosx_plugin.dylib              0x0000000105c6c965 -[VLCMain viewPreferences:] + 69
	15  AppKit                              0x00007fff871bd6d9 -[NSApplication sendAction:to:from:] + 214
	16  AppKit                              0x00007fff872a8b0c -[NSMenuItem _corePerformAction] + 406
	17  AppKit                              0x00007fff872a87fa -[NSCarbonMenuImpl performActionWithHighlightingForItemAtIndex:] + 133
	18  AppKit                              0x00007fff875630b4 -[NSMenu _internalPerformActionForItemAtIndex:] + 36
	19  AppKit                              0x00007fff873d640f -[NSCarbonMenuImpl _carbonCommandProcessEvent:handlerCallRef:] + 135
	20  AppKit                              0x00007fff87224a6d NSSLMMenuEventHandler + 342
	21  HIToolbox                           0x00007fff8c97cdc2 _ZL23DispatchEventToHandlersP14EventTargetRecP14OpaqueEventRefP14HandlerCallRec + 1206
	22  HIToolbox                           0x00007fff8c97c371 _ZL30SendEventToEventTargetInternalP14OpaqueEventRefP20OpaqueEventTargetRefP14HandlerCallRec + 410
	23  HIToolbox                           0x00007fff8c9931c9 SendEventToEventTarget + 40
	24  HIToolbox                           0x00007fff8c9d8a61 _ZL18SendHICommandEventjPK9HICommandjjhPKvP20OpaqueEventTargetRefS5_PP14OpaqueEventRef + 443
	25  HIToolbox                           0x00007fff8cac8195 SendMenuCommandWithContextAndModifiers + 59
	26  HIToolbox                           0x00007fff8cb12b8c SendMenuItemSelectedEvent + 254
	27  HIToolbox                           0x00007fff8c9d1b4d _ZL19FinishMenuSelectionP13SelectionDataP10MenuResultS2_ + 94
	28  HIToolbox                           0x00007fff8c9c93d2 _ZL14MenuSelectCoreP8MenuData5PointdjPP13OpaqueMenuRefPt + 605
	29  HIToolbox                           0x00007fff8c9c8a2f _HandleMenuSelection2 + 565
	30  AppKit                              0x00007fff87125a3c _NSHandleCarbonMenuEvent + 245
	31  AppKit                              0x00007fff870c2857 _DPSNextEvent + 2073
	32  AppKit                              0x00007fff870c1ba9 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 128
	33  AppKit                              0x00007fff870be1d3 -[NSApplication run] + 517
	34  libmacosx_plugin.dylib              0x0000000105c768af Run + 255
	35  libvlccore.4.dylib                  0x00000001030f260f intf_Create + 847
	36  libvlccore.4.dylib                  0x00000001030deb75 libvlc_InternalAddIntf + 213
	37  libvlc.5.dylib                      0x00000001030bd02c libvlc_add_intf + 12
	38  VLC                                 0x00000001030b8c2c main + 428
	39  libdyld.dylib                       0x00007fff8b3917e1 start + 0
	40  ???                                 0x0000000000000002 0x0 + 2
)

Changed 12 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Attachment: VLC-1.1.7-WIP.patch added

VLC-1.1.7-WIP.patch

comment:14 Changed 12 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Cc: jeremyhu@… added

Cc Me!

comment:15 Changed 12 years ago by royliu@…

In all honesty I think we should close out this bug and file a new one for 2.0.1.

comment:16 Changed 12 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Keywords: haspatch removed
Owner: changed from mnick@… to jeremyhu@…
Status: newassigned
Summary: VLC 1.0.6 build fails (have patch to 1.1.7)VLC is out of date

There's no need to create a new bug.

I'm trying to get 2.0.1 building right now. It's not quite there, but you can see the current state in my overlay:

https://github.com/jeremyhu/dports_jeremyhu/tree/master/multimedia/VLC

It's currently dieing in the final stages of the build when it puts together the bundle.

comment:17 Changed 12 years ago by jeremyhu (Jeremy Huddleston Sequoia)

The current failure with 2.0.1 is here:

cd "./modules/gui/macosx/" && cp *.h *.m /opt/local/var/macports/build/_Users_jeremy_src_macports_dports_jeremyhu_multimedia_VLC/VLC/work/vlc-2.0.1/tmp/modules/gui/macosx/
cd ./tmp/extras/package/macosx && \
		xcodebuild -target vlc SYMROOT=../../../build DSTROOT=../../../build 2>&1 >/dev/null
cp -R -L ./tmp/build/Default/VLC.bundle VLC-tmp
mkdir -p VLC-tmp/Contents/MacOS/share/locale/
cp -r "/opt/local/lib/vlc/lua" "/opt/local/share/vlc/lua" VLC-tmp/Contents/MacOS/share/
mkdir -p VLC-tmp/Contents/MacOS/include/
cp -r "./include/vlc" VLC-tmp/Contents/MacOS/include/
/usr/bin/install -c -m 644 ./share/vlc512x512.png VLC-tmp/Contents/MacOS/share/vlc512x512.png
install: ./share/vlc512x512.png: No such file or directory
make[2]: *** [VLC-tmp] Error 71
make[2]: Leaving directory `/opt/local/var/macports/build/_Users_jeremy_src_macports_dports_jeremyhu_multimedia_VLC/VLC/work/vlc-2.0.1'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_Users_jeremy_src_macports_dports_jeremyhu_multimedia_VLC/VLC/work/vlc-2.0.1'
make: *** [all] Error 2
make: Leaving directory `/opt/local/var/macports/build/_Users_jeremy_src_macports_dports_jeremyhu_multimedia_VLC/VLC/work/vlc-2.0.1'
Command failed:  cd "/opt/local/var/macports/build/_Users_jeremy_src_macports_dports_jeremyhu_multimedia_VLC/VLC/work/vlc-2.0.1" && /usr/bin/make -w all DESTDIR=/opt/local/var/macports/build/_Users_jeremy_src_macports_dports_jeremyhu_multimedia_VLC/VLC/work/vlc-2.0.1/dest_ignore 
Exit code: 2
Error: org.macports.build for port VLC returned: command execution failed
Warning: targets not executed for VLC: org.macports.activate org.macports.build org.macports.destroot org.macports.install
Please see the log file for port VLC for details:
    /opt/local/var/macports/logs/_Users_jeremy_src_macports_dports_jeremyhu_multimedia_VLC/VLC/main.log
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets
Error: Processing of port VLC failed

My guess is that vlc512x512.png exists in their repo but wasn't packaged, but it's late now, so I'll take a look again tomorrow or later this week...

comment:18 Changed 12 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Yeah, I'll need to just stuff them in files until https://trac.videolan.org/vlc/ticket/6739 is addressed.

comment:19 Changed 12 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.