Ticket #28356 (closed enhancement: fixed)
eggdrop: minimize use of "system"
| Reported by: | ryandesign@… | Owned by: | dre@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.9.2 |
| Keywords: | Cc: | blackfrog1@… | |
| Port: | eggdrop |
Description
The eggdrop portfile includes this line:
post-destroot { system "cd ${destroot}${prefix}/bin/ && rm ../share/eggdrop/eggdrop && ln -s ../share/eggdrop/eggdrop-${version} eggdrop && mv ../share/eggdrop/eggdrop.conf ../share/eggdrop/eggdrop.conf.sample && mv ../share/eggdrop/doc/man1/eggdrop.1 ../share/man/man1"
All of this can be done with native Tcl commands, which is preferable to using "system".
Attachments
Change History
comment:2 Changed 2 years ago by blackfrog1@…
I took each of the system command and converted them into the Tcl Extension. See attached port patch diff.
Changed 2 years ago by blackfrog1@…
- Attachment Portfile-eggdrop.diff added
system command converted into tcl extension
Note: See
TracTickets for help on using
tickets.
Cc Me!