Opened 13 years ago

Closed 11 years ago

#28806 closed submission (fixed)

New port: gle-graphics

Reported by: jdswinbank (John Swinbank) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: gle-graphics

Description

The Graphics Layout Engine is a scripting language for producing high quality plots & diagrams.

Portfile and patches attached.

Attachments (7)

Portfile (1.8 KB) - added by jdswinbank (John Swinbank) 13 years ago.
patch-qgle-destdir.diff (864 bytes) - added by jdswinbank (John Swinbank) 13 years ago.
patch-qgle-carbon.diff (336 bytes) - added by jdswinbank (John Swinbank) 13 years ago.
Portfile.2 (1.9 KB) - added by jdswinbank (John Swinbank) 12 years ago.
patch-qgle-libgs.diff (916 bytes) - added by jdswinbank (John Swinbank) 12 years ago.
Portfile.3 (1.9 KB) - added by jdswinbank (John Swinbank) 12 years ago.
patch-qgle-glu.diff (930 bytes) - added by jdswinbank (John Swinbank) 12 years ago.

Download all attachments as: .zip

Change History (11)

Changed 13 years ago by jdswinbank (John Swinbank)

Attachment: Portfile added

Changed 13 years ago by jdswinbank (John Swinbank)

Attachment: patch-qgle-destdir.diff added

Changed 13 years ago by jdswinbank (John Swinbank)

Attachment: patch-qgle-carbon.diff added

comment:1 Changed 12 years ago by jmroot (Joshua Root)

Port: gle-graphics added
Version: 1.9.2

The hardcoded /opt/local in the patch needs to be changed to ${prefix} as per PortfileRecipes#hardcode_opt_local. The references to /usr/lib/libgs.dylib and /usr/local/lib/libgs.dylib should be removed as we would never want to load those.

Sorry it's taken so long for this to be reviewed, but tickets that are not assigned to anyone can fall through the cracks. If it appears that a ticket has been forgotten, you can email the macports-dev list.

Changed 12 years ago by jdswinbank (John Swinbank)

Attachment: Portfile.2 added

Changed 12 years ago by jdswinbank (John Swinbank)

Attachment: patch-qgle-libgs.diff added

comment:2 Changed 12 years ago by jdswinbank (John Swinbank)

Thanks for the comments!

I attach an update Portfile, which bumps the version to 4.2.4c, and a reworked version of the patch which strips out all the hard-coded paths and replaces them with a single reference to ${prefix} as requested.

Changed 12 years ago by jdswinbank (John Swinbank)

Attachment: Portfile.3 added

Changed 12 years ago by jdswinbank (John Swinbank)

Attachment: patch-qgle-glu.diff added

comment:3 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Thanks.

comment:4 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Committed in r100859 with these changes:

  • added standard modeline and made some whitespace adjustments
  • removed line "revision 1"; revisions should start at 0
  • indicated the port's license
  • rewrote master_sites to avoid redirects
  • made a QGLE subport instead of a gui variant. Subports are a better model than variants for separately-installable components; they're easier for the user to install later and it also means our buildbot can build them. (The buildbot only builds default_variants.) Also, QGLE is under a different license than gle-graphics; the subport gives us a cleaner way to indicate this to the user.
  • added aqua category to QGLE subport
  • sorted dependencies and rewrote cairo dependency so that cairo-devel could satisfy it
  • moved the patches out of the QGLE subport since they do no harm in the main port, and this will ensure that someone in the future updating the port who forgets to test the QGLE subport will not inadvertently cause its patches to become stale
  • rather than patching platform/script/install_qgle_mac to such an extent that it only copies the application, I just overrode the destroot phase in the QGLE subport and wrote the copy command there
  • added port:poppler library dependency and --with-poppler configure arg since poppler gets used anyway if it's already installed
  • added port:pkgconfig build dependency because without it poppler and cairo do not get found
  • added --with-libgle=yes configure arg so that libgle-graphics-4.2.4c.dylib is always installed, not just when building the GUI
  • added a patch to fix the install_name of libgle-graphics-4.2.4c.dylib
  • in QGLE's About box, the License tab said "File not found: '/opt/local/share/doc/gle-graphics/LICENSE.txt'". It looks like adding "doc" to build.target would install that and README.txt, but would also install the documentation pdf, and while that would be nice, it needs various LaTeX dependencies to build it first. So I just manually installed the text files. We can think about adding a documentation subport later.
  • fixed livecheck
  • disabled universal variant because it doesn't work; I filed #37441 about that
Note: See TracTickets for help on using tickets.