Opened 13 years ago

Closed 13 years ago

#28956 closed submission (fixed)

TortoiseHg Port Submission

Reported by: guidolorenz@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: mercurial Cc:
Port: tortoisehg

Description

This is a Portfile for TortoiseHg 2.0.2, a PyQt4-based GUI for Mercurial.

Attachments (8)

Portfile (1.1 KB) - added by guidolorenz@… 13 years ago.
patch-setup.py.diff (603 bytes) - added by guidolorenz@… 13 years ago.
Portfile.2 (2.2 KB) - added by shiena.jp@… 13 years ago.
config.py (311 bytes) - added by shiena.jp@… 13 years ago.
patch-Makefile.diff (328 bytes) - added by shiena.jp@… 13 years ago.
Portfile.3 (1.7 KB) - added by shiena.jp@… 13 years ago.
config.2.py (219 bytes) - added by shiena.jp@… 13 years ago.
Portfile.4 (1.7 KB) - added by guidolorenz@… 13 years ago.
Updated Portfile for 2.0.3

Download all attachments as: .zip

Change History (14)

Changed 13 years ago by guidolorenz@…

Attachment: Portfile added

Changed 13 years ago by guidolorenz@…

Attachment: patch-setup.py.diff added

comment:1 in reply to:  description Changed 13 years ago by shiena.jp@…

I added the config for the locale, the icon, and the copyright. Because it cannot be displayed that it is a config of default. In addition, "/opt/local/bin/thg" and the html document are added.

Changed 13 years ago by shiena.jp@…

Attachment: Portfile.2 added

Changed 13 years ago by shiena.jp@…

Attachment: config.py added

Changed 13 years ago by shiena.jp@…

Attachment: patch-Makefile.diff added

comment:2 Changed 13 years ago by guidolorenz@…

Hi Shiena,

thanks for your input. I had a look at your changes and have a few questions and comments:

  1. Copying the license file and building the english documentation is a good idea.
  2. Also building czech and japanese documentation seems a bit too much to me. I'm not sure, though -- is there a MacPorts best practice for dealing with localized documentation?
  3. Why do you manually create a symlink for thg in ${prefix}/bin? For me, the python26 port group already created this symlink automatically.
  4. I'm not a big fan of patch files -- instead of patching doc/Makefile, what do you think of calling make like this: make SPHINXBUILD=sphinx-build-2.6 html
  5. Why do we need config.py? To me it seemed like the auto-detection mechanisms worked fine. If we want to use a custom config.py, we must replace the hardcoded "/opt/local" by the value of ${prefix}.

Cheers, Guido

comment:3 in reply to:  2 Changed 13 years ago by shiena.jp@…

Hi Guido

Thank you for seeing my file.

  1. Copying the license file and building the english documentation is a good idea.

Thank you.

  1. Also building czech and japanese documentation seems a bit too much to me. I'm not sure, though -- is there a MacPorts best practice for dealing with localized documentation?

There is especially no intention though I did all documents in the build.

  1. Why do you manually create a symlink for thg in ${prefix}/bin? For me, the python26 port group already created this symlink automatically.

It is my mistake. I misunderstood it while a variety of trying. A symlink need not be made by manually.

  1. I'm not a big fan of patch files -- instead of patching doc/Makefile, what do you think of calling make like this: make SPHINXBUILD=sphinx-build-2.6 html

I am this feeling. Your method is good. The method had been forgotten.

  1. Why do we need config.py? To me it seemed like the auto-detection mechanisms worked fine. If we want to use a custom config.py, we must replace the hardcoded "/opt/local" by the value of ${prefix}.

I explain the content of config.py respectively.

bin_path

This is added to PATH for the hg command. I set for the time being "/opt/local/bin". However, "${prefix}/bin" is better as you say.

license_path

This specifies the text displayed in the license dialog. When path is wrong, it becomes blank.

locale_path

If this passing is correct, it comes to be able to select UI Language of the TortoiseHG Setting dialog. I want to select the mother tongue (Japanese).

icon_path

This specifies passing icon as well as locale_path. However, the Qt library seems to detect the setting of default automatically.

nofork

This is the same as default.

I corrected Portfile and config.py from your questions.

Changed 13 years ago by shiena.jp@…

Attachment: Portfile.3 added

Changed 13 years ago by shiena.jp@…

Attachment: config.2.py added

Changed 13 years ago by guidolorenz@…

Attachment: Portfile.4 added

Updated Portfile for 2.0.3

comment:4 Changed 13 years ago by guidolorenz@…

Shiena, thanks for the updated Portfile. I changed the version number to 2.0.3, because it has been released in the meantime.

To me, the port seems ready to be committed now.

comment:5 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Port: tortoisehg added
Status: newassigned

comment:6 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Committed in r78450 with some changes:

  • removed md5 checksum (we're gradually removing it from MacPorts)
  • changed runtime dependencies to library dependencies (e.g. "sudo port build" failed without py26-pyqt4 installed)
  • did patching in post-patch and copying extra files in post-extract, instead of both in pre-build
  • added "supported_archs noarch" since this port doesn't seem to install any architecture-specific files; removed "universal_variant no" since "supported_archs noarch" implies it

I see 2.0.4 is already available; if you'd like to update to that version, please supply a diff in a new ticket.

Note: See TracTickets for help on using tickets.