#29129 closed enhancement (fixed)
fetch.type svn: don't ignore SSL certificates unless port says to
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | MacPorts 2.9.0 |
| Component: | base | Version: | 1.9.2 |
| Keywords: | Cc: | mascguy (Christopher Nielsen) | |
| Port: |
Description
Since r54434, when using fetch.type svn, MacPorts checks out Subversion working copies using the --trust-server-cert option. MacPorts should only trust unknown SSL certificates if the port says fetch.ignore_sslcert yes.
Support for the --trust-server-cert option is also the only reason why MacPorts depends on the subversion port when the OS is less than Snow Leopard; this requirement could be removed if the port doesn't need to ignore the certificate.
Change History (8)
comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Type: | defect → enhancement |
|---|
comment:2 follow-up: 3 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
comment:3 Changed 12 years ago by jmroot (Joshua Root)
Replying to ryandesign@…:
(has somebody filed a RADAR bug?)
rdar://problem/11116033
Feel free to file a(nother) dupe.
comment:4 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)
We are still unconditionally using --trust-server-cert for svn fetches, and we should still stop doing that unless explicitly requested by the port.
But in the mean time, MacPorts base requires the subversion port on OS X El Capitan and earlier because their /usr/bin/svn doesn't support TLS. So the concern about unnecessarily requiring the subversion port on old OS versions is no longer applicable.
comment:5 Changed 2 years ago by mascguy (Christopher Nielsen)
| Cc: | mascguy added |
|---|
comment:6 Changed 13 months ago by jmroot (Joshua Root)
Partially fixed in [4acfd686dc1e88befaf288c549d7e895e1b13347/macports-base]
comment:7 Changed 13 months ago by jmroot (Joshua Root)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:8 Changed 5 months ago by jmroot (Joshua Root)
| Milestone: | MacPorts Future → MacPorts 2.9.0 |
|---|
The svn bundled with Lion apparently has its own issues verifying ssl certificates (has somebody filed a RADAR bug?), which means we'd either have to continue ignoring certificates on Lion or require the subversion port on Lion.