Opened 13 years ago

Closed 12 years ago

#29256 closed enhancement (fixed)

octave-3.2.4: a patch to use accelerate on x86-64

Reported by: tenomoto (Takeshi Enomoto) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc: jmroot (Joshua Root)
Port: octave

Description

With the attached patch, it builds with +g95 and +gcc45 on x86-64. It fixes a bug in g95 variant (g95 does not have -ff2c). In addition accelerate variant is renamed as no_atlas, which is more common (I was told to do so in the past).

Attachments (2)

Portfile.diff (2.3 KB) - added by tenomoto (Takeshi Enomoto) 13 years ago.
Portfile.2.diff (1.5 KB) - added by tenomoto (Takeshi Enomoto) 13 years ago.

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by tenomoto (Takeshi Enomoto)

Attachment: Portfile.diff added

comment:1 in reply to:  description Changed 13 years ago by jmroot (Joshua Root)

Replying to takeshi@…:

In addition accelerate variant is renamed as no_atlas, which is more common (I was told to do so in the past).

I think you were probably told that when negated variants were not yet being recorded. Now that they are, it makes more sense to have +foo and let the user specify -foo, rather than having +no_foo. So basically, I think all the other ports that use no_atlas are the ones that should change. :-)

comment:2 Changed 13 years ago by tenomoto (Takeshi Enomoto)

That makes sense. Leave accelerate as it is.

Changed 13 years ago by tenomoto (Takeshi Enomoto)

Attachment: Portfile.2.diff added

comment:3 Changed 12 years ago by jmroot (Joshua Root)

Owner: changed from stechert@… to macports-tickets@…

-> nomaintainer

comment:4 Changed 12 years ago by tenomoto (Takeshi Enomoto)

Resolution: fixed
Status: newclosed

I forgot to close this ticket. Committed in r81037.

Note: See TracTickets for help on using tickets.