Opened 13 years ago
Closed 13 years ago
#29422 closed defect (fixed)
Quicksilver: build fails on case-sensitive file systems
| Reported by: | carsomyr@… | Owned by: | singingwolfboy@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.9.2 |
| Keywords: | haspatch | Cc: | singingwolfboy@… |
| Port: | Quicksilver |
Description
Please find attached patches for the Quicksilver Portfile and Xcode project file to fix a case sensitivity issue with the build.
Attachments (3)
Change History (9)
Changed 13 years ago by carsomyr@…
| Attachment: | patch-Portfile.diff added |
|---|
Changed 13 years ago by carsomyr@…
| Attachment: | patch-project.pbxproj.diff added |
|---|
The Xcode project file patch.
comment:1 Changed 13 years ago by singingwolfboy@…
| Owner: | changed from macports-tickets@… to singingwolfboy@… |
|---|---|
| Status: | new → assigned |
comment:2 Changed 13 years ago by singingwolfboy@…
This seems like it would be better addressed by submitting a patch upstream. I'll give that a shot before applying this patch in Macports.
comment:3 Changed 13 years ago by singingwolfboy@…
My upstream patch was accepted. Can you do a selfupdate and try building Quicksilver again? Hopefully, the problem should be fixed.
comment:4 Changed 13 years ago by carsomyr@…
Do you think they're going to change the B-59 tag? If not, the problem will persist. I had to change the Portfile to use the version "master" -- no biggie. Two more things:
- destroot installs things in "/Library/Application Support". Is this intended?
- The build process is installing Quicksilver.app in /Applications. This is definitely not intended.
Changed 13 years ago by carsomyr@…
| Attachment: | patch-project.pbxproj.2.diff added |
|---|
Patch to disable installing after the build.
comment:5 Changed 13 years ago by carsomyr@…
FYI, I've attached patch-project.pbxproj.2.diff, which disables installation of Quicksilver.app into /Applications.
comment:6 Changed 13 years ago by singingwolfboy@…
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Committed in r78556. I switched the first project.pbxproj patch to a reinplace line to make it more flexible, and I included the second patch as-is (with a more descriptive filename).
The installation into "/Library/Application Support" is intentional, since the installation builds a few core plugins and that is the proper place for system plugins to go. The release Quicksilver application bundles contain the plugins inside the application bundle, but I figured it would be cleaner to put them in "/Library/Application Support", since user plugins get installed into "~/Library/Application Support". Is this directory outside of the Macports domain, or is there some other reason why files shouldn't be installed there?
The Portfile patch.