Opened 13 years ago

Closed 13 years ago

#29622 closed update (fixed)

fossil: fix #29591, don't build windows specific files, remove -O2 CFLAG

Reported by: ci42 Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch maintainer Cc:
Port: fossil

Description

changes:

  • include upstream fix for #29591
  • don't create the windows specific make files
  • remove -O2 from ${configure.cflags} as it is inconsistence with the -Os flag set by the makefile

Attachments (3)

fossil.diff (23.3 KB) - added by ci42 13 years ago.
do not touch optimization flags
fossil-configure.optflags.diff (23.3 KB) - added by ci42 13 years ago.
set ${configure.optflags} to -Os
fossil-configure.optflags-delete.diff (23.3 KB) - added by ci42 13 years ago.
delete -O2 from ${configure.optflags}

Download all attachments as: .zip

Change History (6)

comment:1 in reply to:  description ; Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Replying to ciserlohn@…:

  • remove -O2 from ${configure.cflags} as it is inconsistence with the -Os flag set by the makefile

I see that they use -Os, and then MacPorts adds its -O2 after, which should mean -O2 takes precedence. The port seemed to build fine with -O2... are you saying the program will work better with -Os?

If so, I think the preferred way to indicate this is not:

configure.cflags-delete -O2

but instead:

configure.optflags  -Os

Changed 13 years ago by ci42

Attachment: fossil.diff added

do not touch optimization flags

Changed 13 years ago by ci42

set ${configure.optflags} to -Os

Changed 13 years ago by ci42

delete -O2 from ${configure.optflags}

comment:2 in reply to:  1 Changed 13 years ago by ci42

Replying to ryandesign@…:

Replying to ciserlohn@…:

  • remove -O2 from ${configure.cflags} as it is inconsistence with the -Os flag set by the makefile

I see that they use -Os, and then MacPorts adds its -O2 after, which should mean -O2 takes precedence. The port seemed to build fine with -O2... are you saying the program will work better with -Os?

Not that I'm aware of. It is only a precautionary measure to not hit problems with -O2 as the upstream developer test their versions with -Os. Additionally they strive to avoid bloat. I think -Os is well-suited for that goal - the actual file sizes are 1.5M for -Os vs. 1.6M for -O2 and 2.8M vs. 3.0M for the universal variant.

If so, I think the preferred way to indicate this is not:

configure.cflags-delete -O2

but instead:

configure.optflags  -Os

Yes, configure.optflags is the right place, but wouldn't be

configure.optflags-delete -O2

the right thing to do. Otherwise we would add -Os twice.

Anyway, I added patches for all three options, feel free to pick the one you think is the most appropriate.

comment:3 Changed 13 years ago by ci42

Resolution: fixed
Status: assignedclosed

fixed in r79813

Note: See TracTickets for help on using tickets.