Opened 13 years ago

Closed 13 years ago

#29679 closed update (fixed)

roboctl 0.3.6 maintainer update

Reported by: jwbacon@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: maintainer haspatch Cc: mf2k (Frank Schima)
Port: roboctl

Description

Bug fixes and minor enhancements to both Lego and Vex communication tools.

Attachments (2)

Portfile (1.2 KB) - added by jwbacon@… 13 years ago.
Portfile-diff.txt (1.2 KB) - added by jwbacon@… 13 years ago.

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by jwbacon@…

Attachment: Portfile added

comment:1 Changed 13 years ago by mf2k (Frank Schima)

Version: 1.9.2

Please attach a unified diff instead of a complete Portfile so we can easily see the changes. Thanks!

comment:2 Changed 13 years ago by mf2k (Frank Schima)

Cc: macsforever2000@… added

Cc Me!

Changed 13 years ago by jwbacon@…

Attachment: Portfile-diff.txt added

comment:3 in reply to:  1 Changed 13 years ago by jwbacon@…

Replying to macsforever2000@…:

Please attach a unified diff instead of a complete Portfile so we can easily see the changes. Thanks!

Done.

comment:4 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Thanks.

comment:5 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Committed in r79090 with these changes:

  • left the checksums where they were near the top of the file, which is where most other portfiles have them
  • indicated this is under the BSD license
  • ensured we're UsingTheRight compiler and the right build arch
  • changed how "make depend" is run so it gets the build.args
  • changed the removal of -lbluetooth into a patchfile instead of a reinplace (it's easier to see by looking at the patchfile what's happening, and it provides context which can be useful in the future when updating the port)
  • fixed the "echo -e" => "echo" reinplace: the 3 files that were being reinplaced no longer contain that string, but a different file does; changed this to a patch too
Note: See TracTickets for help on using tickets.