New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #30704 (closed enhancement: fixed)

Opened 22 months ago

Last modified 21 months ago

git-core: support Perl-compatible regexes

Reported by: carsomyr@… Owned by: maccheck@…
Priority: Normal Milestone:
Component: ports Version: 2.0.99
Keywords: haspatch Cc: cal@…
Port: git-core

Description

When trying to use "git grep" with the "-P" option, I get

cannot use Perl-compatible regexes when not compiled with USE_LIBPCRE

I've attached a patch that adds PCRE support through the pcre Port.

Attachments

Portfile (6.1 KB) - added by carsomyr@… 21 months ago.
The Portfile (revision 2).
patch-Portfile.diff (803 bytes) - added by carsomyr@… 21 months ago.
The Portfile patch (revision 3).

Change History

comment:1 Changed 21 months ago by carsomyr@…

I've reattached the Portfile to reflect underlying changes to the git-core Port.

Changed 21 months ago by carsomyr@…

The Portfile (revision 2).

comment:2 follow-up: ↓ 3 Changed 21 months ago by cal@…

  • Cc cal@… added; maccheck@… removed
  • Owner changed from macports-tickets@… to maccheck@…

I wonder whether we should make this a variant, or add it by default.

Changed 21 months ago by carsomyr@…

The Portfile patch (revision 3).

comment:3 in reply to: ↑ 2 Changed 21 months ago by carsomyr@…

Good point! I've reattached patch-Portfile.diff. libpcre support is now a variant. Please rebuild and see if "git grep -P" works (if libpcre support isn't there, then git will just complain and do nothing).

Replying to cal@…:

I wonder whether we should make this a variant, or add it by default.

comment:4 Changed 21 months ago by cal@…

  • Status changed from new to closed
  • Resolution set to fixed

Commited in r83536.

Note: See TracTickets for help on using tickets.