New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #31004 (closed defect: fixed)

Opened 21 months ago

Last modified 13 months ago

nginx should not own nginx.conf

Reported by: ast@… Owned by: cal@…
Priority: Normal Milestone:
Component: ports Version: 2.0.1
Keywords: Cc:
Port: nginx

Description (last modified by ryandesign@…) (diff)

Just hit this one today when I was trying to configure nginx with SSL on my development machine. Had made all the required changes to configure a new server instance in my nginx.conf (I don't use subconfigs on this box), and then got this message:

valkyrie$ sudo nginx -s reload
nginx: [emerg] unknown directive "ssl" in /opt/local/etc/nginx/nginx.conf:99

Finding this page http://kete.net.nz/documentation/topics/show/167-configure-nginx-to-use-ssl, I followed the instructions, but once I'd deactivated nginx, it deleted my nginx.conf file!

Even RPM got this right over 15 years ago, so I can't understand why this package has so much trouble whacking configuration files (see my other ticket: #27354).

The nginx.conf file shouldn't be part of the files managed by the installation, or if it is, it needs to be checked against either a modification time or a hash value of the package one so that these problems don't happen.

Change History

comment:1 Changed 21 months ago by ryandesign@…

  • Keywords nginx.conf delete modified removed
  • Owner changed from macports-tickets@… to boeyms@…
  • Description modified (diff)
  • Summary changed from port deactivate nginx deletes modified nginx.conf to nginx should not own nginx.conf

Apologies for the trouble. You're right, nginx should not own the nginx conf file. Instead it should install a sample conf file, and advise the user how to copy it. Many of our other ports do this, but nginx has not yet been set up that way.

comment:2 Changed 19 months ago by boeyms@…

  • Owner changed from boeyms@… to macports-tickets@…

Reassigning to macports-tickets@… as I have relinquished ownership of this port.

comment:3 Changed 13 months ago by ryandesign@…

  • Description modified (diff)

comment:4 Changed 13 months ago by ryandesign@…

  • Owner changed from macports-tickets@… to cal@…

There's a patch for this submitted in #34188.

comment:5 Changed 13 months ago by cal@…

  • Status changed from new to closed
  • Resolution set to fixed

This has already been fixed for nginx.conf for quite a while now. I applied the relevant parts from #34188 for the other files in $prefix/etc/nginx in r92300.

Note: See TracTickets for help on using tickets.